Installing v0.2.3 with Intel Compiler

[johnyaku]

In order to compile v0.2.3 with Intel Compiler I had to edit the source as follows:

preprocessor.h

Change

#ifdef NDEBUG
    #define TOML_ASSERT_ASSUME(expr) TOML_ASSUME(expr)
#else
    #define TOML_ASSERT_ASSUME(expr) TOML_ASSERT(expr)
#endif

to

#ifdef __INTEL_COMPILER
    #define TOML_ASSERT_ASSUME(expr) ((void)0)
#else
    #ifdef NDEBUG
        #define TOML_ASSERT_ASSUME(expr) TOML_ASSUME(expr)
    #else
        #define TOML_ASSERT_ASSUME(expr) TOML_ASSERT(expr)
    #endif
#endif

node.h

Added the following immediately after TOML_NAMESPACE_END;

namespace toml::v3 {
    inline const table* node::as_table() const noexcept {
        return nullptr;
    }
    inline bool node::is_array() const noexcept {
        return false;
    }
    inline bool node::is_array_of_tables() const noexcept {
        return false;
    }
    inline node_type node::type() const noexcept {
        return node_type::none;
    }
    inline bool node::is_table() const noexcept {
        return false;
    }
    inline bool node::is_value() const noexcept {
        return false;
    }
}

[eddelbuettel]

For the first change, why does this not work? There is a TOML_ICC case:

rcpptoml/inst/include/toml++/impl/preprocessor.h

Lines 327 to 334 in f50fe96

	// TOML_ASSUME
	#ifdef _MSC_VER
	#define TOML_ASSUME(...) __assume(__VA_ARGS__)
	#elif TOML_ICC || TOML_CLANG || TOML_HAS_BUILTIN(__builtin_assume)
	#define TOML_ASSUME(...) __builtin_assume(__VA_ARGS__)
	#else
	#define TOML_ASSUME(...) static_assert(true)
	#endif

For the second: after whcih TOML_NAMESPACE_END? I see them on lines 1103 and 1112. We may also wantr to protect this via a #if defined(TOML_ICC).

I am not opposed to making the changes but this is ultimately something for toml++ upstream. Have you discussed it there, or has there been a discussion?