You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit caps off the process of extracting the `web-monitoring-diff` package from the old `web-monitoring-processing` repo! There's a lot happening here:
- The README has been almost entirely rewritten.
- `setup.py` has been updated for this package.
- Versioneer has been updated.
- Requirements have been slimmed down to just what's needed for this codebase.
- Requirements can be installed via `pip install web-monitoring-diff` or `pip install web-monitoring-diff[server,dev]`. `requirements.txt` files are not needed except for Docker and "experimental" diffs.
- The server script has been renamed to `web-monitoring-diff-server` to match the package name. It's long, but now that we are treating this as more abstract, I'm leery of abbreviating as much.
- Modules have been moved around and renamed. `web_monitoring_diff.diff.<whatever>` and `web_monitoring_diff.diff_server` both seemed pretty redundant, so we now have:
- `web_monitoring_diff.<diff_function>` -- all the diff functions are exposed directly at the top level.
- The actual submodules containing diff functions are named `<whatever>_diff.py`:
- `basic_diffs.py` instead of `differs` to be more clear that these are relatively simple functions all thrown together.
- `html_render_diff.py` instead of `html_diff_render.py` to fit the convention.
- `html_links_diff.py` instead of `links_diff.py` to clarify that this is for HTML documents.
- `experimental/<wrapped_package_name>.py` contains the diffs that are no longer actively used and were never especially well supported. They have to be installed by via git instead of PyPI, so setup is also kind of special. Since they need extra special installation support, importing them may fail, and so each one is in a separate module. I've also tried to document the issues and concerns around each of them much more than we had anywhere before.
- `web_monitoring_diff.exceptions` as a common standard for where our exception types belong.
- `web_monitoring_diff.server` for the server. It's a subpackage since the content of the server module is so big. I think it's a pretty obvious future plan to refactor that megamodule into smaller files and this lets us do so.
- `deployment.md` has been removed -- it's no longer relevant.
- Switch to flake8 for linting
Layer dependencies better in Dockerfile
Fix CircleCI dependencies
Switch to flake8 for linting (but limit it a lot)
0 commit comments