Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cChardet and html5-parser (and lxml?) optional #196

Open
Mr0grog opened this issue Feb 3, 2025 · 0 comments
Open

Make cChardet and html5-parser (and lxml?) optional #196

Mr0grog opened this issue Feb 3, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Feb 3, 2025

We have quite a bit of pain caused by a few compiled dependencies that don’t always build correctly on all environments or the latest Python versions:

All of these have drop in replacements (even though they are very slow). We could probably make this package easier to use by using the slower, pure-python versions by default, and allowing people to use the faster, compiled ones via extras, e.g. pip install web-monitoring-diff[c-extensions] or something.

Some questions:

  • Should these all be bundled in one extra (“give me the speedy-but-complicated deps”), or should each package be a separate extension (“give me just accelerated chardet, but not HTML parsing”)?
  • Should the pure-Python versions be part of the base package (so pip install web-monitoring-diff get you something that just works, but you get a bloated set of dependencies you don’t use if you install the speedier extras), or should they also be an extra (i.e. install either web-monitoring-diff[pure-python] OR web-monitoring-diff[c-extensions]; just installing web-monitoring-diff won’t work).
@Mr0grog Mr0grog added the enhancement New feature or request label Feb 3, 2025
@Mr0grog Mr0grog moved this to Inbox in Web Monitoring Feb 17, 2025
@Mr0grog Mr0grog moved this from Inbox to Backlog in Web Monitoring Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant