Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending client (4xx) and upstream (502, 504) errors to Sentry #21

Open
Mr0grog opened this issue Jul 6, 2020 · 0 comments
Open
Labels
server Specific to the diffing server, rather than diff algorithms

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Jul 6, 2020

We currently send information about every kind of error we currently encounter to Sentry, including errors that were not internal (i.e. bad requests by the client or upstream errors from the requested URLs to diff). Those non-internal errors are “expected” in the sense that they don’t represent a problem with the differ, and probably don’t make sense to send to Sentry. For EDGI’s case, they also represent the vast majority of what we send to Sentry, which is problematic because it can push us towards quota limits.

These kinds of errors are probably better handled with logs and with metrics than with Sentry, and so we probably shouldn’t send them to Sentry. If other deployments need them (e.g. Internet Archive), we could probably add an environment variable to control it. (Maybe SEND_EXTERNAL_ERRORS?)

@Mr0grog Mr0grog transferred this issue from edgi-govdata-archiving/web-monitoring-processing Oct 26, 2020
@Mr0grog Mr0grog added the server Specific to the diffing server, rather than diff algorithms label Nov 5, 2020
@stale stale bot added the stale label Jun 2, 2021
@stale stale bot closed this as completed Jun 16, 2021
@Mr0grog Mr0grog reopened this Jun 18, 2021
@stale stale bot removed the stale label Jun 18, 2021
@edgi-govdata-archiving edgi-govdata-archiving deleted a comment from stale bot Jun 18, 2021
@stale stale bot added the stale label Jan 8, 2022
@stale stale bot closed this as completed Apr 16, 2022
@Mr0grog Mr0grog reopened this Apr 17, 2022
@stale stale bot removed the stale label Apr 17, 2022
@edgi-govdata-archiving edgi-govdata-archiving deleted a comment from stale bot Apr 17, 2022
@Mr0grog Mr0grog moved this to Inbox in Web Monitoring Feb 17, 2025
@Mr0grog Mr0grog moved this from Inbox to Backlog in Web Monitoring Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Specific to the diffing server, rather than diff algorithms
Projects
Status: Backlog
Development

No branches or pull requests

1 participant