Skip to content

Commit e8f4445

Browse files
mposik1983mposik1983
committed
address review comments
1 parent 19dacbd commit e8f4445

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

‎compact/tracking/mpgd_barrel.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
<constant name="MMCentral_gap" value="0.2*cm"/>
5353

5454
<comment> In principle, stave count should not be independenty specified: it is fixed by above intrinsic parameters </comment>
55-
<comment> 1.3cm is to make envelope match CAD drawings </comment>
55+
<comment> Factor of 1.3cm on InnerMPGDBarrelLayer_rmax is to extend radial envelope to match 03-12-2025 CAD envelope </comment>
5656
<constant name="MPGDBarrelStave_count" value="8"/>
5757
<constant name="InnerMPGDBarrelLayer_rmin" value="InnerMPGDBarrel_rmin"/>
5858
<constant name="InnerMPGDBarrelLayer_rmax" value="MMOuterSector_R + MMRadial_offset / 2 + 1*cm +1.3*cm"/>

‎compact/tracking/mpgd_outerbarrel.xml‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
<constant name="MPGDOuterBarrelModule_width" value="360*mm"/>
2727
<constant name="MPGDOuterBarrel_length" value="MPGDOuterBarrelModule_zmin1 + MPGDOuterBarrelModule_zmin2"/>
2828
<constant name="MPGDOuterBarrelModule_length" value="0.5*(MPGDOuterBarrelModule_zmin1 + MPGDOuterBarrelModule_zmin2 + MPGDOuterBarrelModule_zoverlap)"/>
29-
<constant name="MPGDOuterBarrelModule_offset" value="(MPGDOuterBarrelModule_zmin2 - MPGDOuterBarrelModule_zmin1)"/>
30-
<constant name="MPGDOuterBarrelModule_feb_ext" value="110*mm"/>
29+
<constant name="MPGDOuterBarrelModule_offset" value="0.5*(MPGDOuterBarrelModule_zmin2 - MPGDOuterBarrelModule_zmin1)"/>
30+
<constant name="MPGDOuterBarrelModule_PCB_offset" value="110*mm"/>
3131
<constant name="MPGDOuterStrip_range" value="(MPGDOuterBarrelModule_length + MPGDOuterBarrelModule_width)/2.0*sqrt(2)"/>
3232

3333
<comment> Layer parameters </comment>
@@ -58,78 +58,78 @@
5858
width="MPGDOuterBarrelModule_width"
5959
thickness="MPGDOuterBarrelDriftGap_thickness"
6060
vis="TrackerMPGDGasVis"
61-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
61+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
6262

6363
<module_component name="WindowGasGap"
6464
material="Ar90IsoButane"
6565
sensitive="false"
6666
width="MPGDOuterBarrelModule_width"
6767
thickness="MPGDOuterBarrelWindowGap_thickness"
6868
vis="TrackerMPGDGasVis"
69-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
69+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
7070
<module_component name="Window"
7171
material="Kapton"
7272
sensitive="false"
7373
width="MPGDOuterBarrelModule_width"
7474
thickness="MPGDOuterBarrelWindow_thickness"
7575
vis="TrackerVis"
76-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
76+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
7777
<module_component name="Cathode_Kapton"
7878
material="Kapton"
7979
sensitive="false"
8080
width="MPGDOuterBarrelModule_width"
8181
thickness="MPGDOuterBarrelFoilKapton_thickness"
8282
vis="TrackerVis"
83-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
83+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
8484
<module_component name="Cathode_Cu"
8585
material="Copper"
8686
sensitive="false"
8787
width="MPGDOuterBarrelModule_width"
8888
thickness="MPGDOuterBarrelFoilCu_thickness"
8989
vis="TrackerVis"
90-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
90+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
9191
<module_component name="RWELL_Cu"
9292
material="Copper"
9393
sensitive="false"
9494
width="MPGDOuterBarrelModule_width"
9595
thickness="MPGDOuterBarrelFoilCu_thickness"
9696
vis="TrackerVis"
97-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
97+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
9898
<module_component name="RWELL_Kapton"
9999
material="Kapton"
100100
sensitive="false"
101101
width="MPGDOuterBarrelModule_width"
102102
thickness="MPGDOuterBarrelFoilKapton_thickness"
103103
vis="TrackerVis"
104-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
104+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
105105
<module_component name="Nomex"
106106
material="Nomex"
107107
sensitive="false"
108108
width="MPGDOuterBarrelModule_width"
109109
thickness="MPGDOuterBarrelReadOutNomex_thickness"
110110
vis="TrackerVis"
111-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
111+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
112112
<module_component name="ReadOutElectrodes"
113113
material="Copper"
114114
sensitive="false"
115115
width="MPGDOuterBarrelModule_width"
116116
thickness="MPGDOuterBarrelReadOutElectrode_thickness"
117117
vis="TrackerVis"
118-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
118+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
119119
<module_component name="ReadOutKapton"
120120
material="Kapton"
121121
sensitive="false"
122122
width="MPGDOuterBarrelModule_width"
123123
thickness="MPGDOuterBarrelReadOutKapton_thickness"
124124
vis="TrackerVis"
125-
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_feb_ext"/>
125+
length="MPGDOuterBarrelModule_length - MPGDOuterBarrelModule_PCB_offset"/>
126126
<module_component name="PCB"
127127
material="Fr4"
128128
sensitive="false"
129129
width="MPGDOuterBarrelModule_width"
130130
thickness="MPGDOuterBarrelPCB_thickness"
131131
vis="TrackerVis"
132-
offset="MPGDOuterBarrelModule_feb_ext"
132+
offset="MPGDOuterBarrelModule_PCB_offset"
133133
length="MPGDOuterBarrelModule_length"/>
134134

135135
<comment> Frame width gets subtracted from the gas module volumes

0 commit comments

Comments
 (0)