diff --git a/compact/definitions.xml b/compact/definitions.xml index c4ec7b2d09..f937e1d5b4 100644 --- a/compact/definitions.xml +++ b/compact/definitions.xml @@ -9,10 +9,17 @@ ## World volume - - - - + + + + + + + + + + + ## Detector IDs diff --git a/compact/far_forward/vacuum.xml b/compact/far_forward/vacuum.xml index 15b2688ca6..cb3dd62d41 100644 --- a/compact/far_forward/vacuum.xml +++ b/compact/far_forward/vacuum.xml @@ -59,6 +59,8 @@ + + diff --git a/compact/tracking/central_tracker_hybrid_v2.xml b/compact/tracking/central_tracker_hybrid_v2.xml index 925192edfe..a4aa68a661 100644 --- a/compact/tracking/central_tracker_hybrid_v2.xml +++ b/compact/tracking/central_tracker_hybrid_v2.xml @@ -156,8 +156,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + Place asymmetrically in the layer (module sits near the bottom). @@ -238,7 +238,7 @@ total X0 0.24% per disk layer (4 sectors per disk): Global Si endcap variables - + @@ -259,11 +259,11 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + - - + + @@ -565,8 +565,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + @@ -576,8 +576,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + The tracker endcap ends at the same place as the outer tracker barrel that sits around it @@ -762,8 +762,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + @@ -772,8 +772,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + @@ -782,8 +782,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + The Si tracker endcap ends at position of the last disk @@ -800,8 +800,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + @@ -810,8 +810,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + The Si tracker endcap ends at position of the last disk @@ -973,7 +973,7 @@ total X0 0.24% per disk layer (4 sectors per disk): - + Parameters for the "ring" GEMS around the silicon tracker, which are all identical @@ -993,8 +993,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + z position of the "ring" GEMS, note that some are offset slightly @@ -1031,8 +1031,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + diff --git a/compact/tracking/silicon_barrel.xml b/compact/tracking/silicon_barrel.xml index 4fbce770b5..b71747560c 100644 --- a/compact/tracking/silicon_barrel.xml +++ b/compact/tracking/silicon_barrel.xml @@ -31,9 +31,9 @@ 84cm=2*42cm is the engineer max - - - + + + diff --git a/compact/tracking/silicon_disks.xml b/compact/tracking/silicon_disks.xml index 94ac075ea6..6c37ba5007 100644 --- a/compact/tracking/silicon_disks.xml +++ b/compact/tracking/silicon_disks.xml @@ -28,7 +28,7 @@ Global Si endcap variables - + Acts envelope buffer distances @@ -46,8 +46,8 @@ - - + + @@ -56,8 +56,8 @@ - - + + @@ -134,8 +134,8 @@ - - + + @@ -143,8 +143,8 @@ - - + + @@ -152,8 +152,8 @@ - - + + @@ -161,8 +161,8 @@ - - + + @@ -171,8 +171,8 @@ - - + + @@ -180,8 +180,8 @@ - - + + @@ -189,8 +189,8 @@ - - + + symmetric N and P disks (5 each) @@ -199,8 +199,8 @@ - - + + diff --git a/compact/tracking/tof_endcap.xml b/compact/tracking/tof_endcap.xml index 7ee623b249..0988b0fabb 100644 --- a/compact/tracking/tof_endcap.xml +++ b/compact/tracking/tof_endcap.xml @@ -107,8 +107,8 @@ - - + + diff --git a/compact/tracking/vertex_barrel.xml b/compact/tracking/vertex_barrel.xml index f2fc4ad20b..9c7395c0ff 100644 --- a/compact/tracking/vertex_barrel.xml +++ b/compact/tracking/vertex_barrel.xml @@ -27,7 +27,7 @@ - + diff --git a/src/magnetVacuumFF.cpp b/src/magnetVacuumFF.cpp index 2f26763206..7f924778d2 100644 --- a/src/magnetVacuumFF.cpp +++ b/src/magnetVacuumFF.cpp @@ -99,6 +99,9 @@ static Ref_t create_detector(Detector& det, xml_h e, SensitiveDetector /* sens * z_elem_magnet.push_back(pos_z * dd4hep::cm); } + xml_comp_t x_end_of_the_world = x_det.child(_Unicode(end_of_the_world)); + double end_of_the_world_z = x_end_of_the_world.attr(_Unicode(z)); + int numMagnets = radii_magnet.size(); //number of actual FF magnets between IP and FF detectors int numGaps = numMagnets - @@ -265,7 +268,7 @@ static Ref_t create_detector(Detector& det, xml_h e, SensitiveDetector /* sens * int pieceIdx = numMagnets - 1; // last B2PF magnet std::string piece_name = Form("GapVacuum%d", numGaps + numMagnets + 1); - double endGapLength = (10000.0 - z_end[pieceIdx]) / cos(rotation_magnet[pieceIdx]); + double endGapLength = (end_of_the_world_z - z_end[pieceIdx]) / cos(rotation_magnet[pieceIdx]); endGapLength = endGapLength - 4 * radii_magnet[pieceIdx] * diff --git a/templates/epic.xml.jinja2 b/templates/epic.xml.jinja2 index 687347a0e4..107c2836b9 100644 --- a/templates/epic.xml.jinja2 +++ b/templates/epic.xml.jinja2 @@ -93,10 +93,18 @@ ## World Volume - The world is a simple box, but could be a union of multiple regions. + The world is a union of multiple regions. - + + + + + + + + +