Handled NullPointerException in SemanticService for missing fields. (#121)

Author: Divya-Kuppula

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 2.0.8
+- Handled NullPointerException in SemanticService for missing fields.
+
 ## 2.0.7
 - Added the link types FAILED_ISSUE,INCONCLUSIVE_ISSUE and SUCCESSFUL_ISSUE in IssueVerified event.
 

pom.xml

@@ -7,7 +7,7 @@
         <version>2.0.2</version>
     </parent>
     <artifactId>eiffel-remrem-semantics</artifactId>
-    <version>2.0.7</version>
+    <version>2.0.8</version>
     <packaging>jar</packaging>
     <properties>
         <eclipse.jgit.version>5.0.1.201806211838-r</eclipse.jgit.version>

src/main/java/com/ericsson/eiffel/remrem/semantics/SemanticsService.java

@@ -203,8 +203,18 @@ public String generateMsg(String msgType, JsonObject bodyJson) {
             }
             Class<? extends Event> eventType = eventTypes.get(eiffelType);
 
-            JsonObject msgNodes = bodyJson.get(MSG_PARAMS).getAsJsonObject();
-            JsonObject eventNodes = bodyJson.get(EVENT_PARAMS).getAsJsonObject();
+            JsonObject msgNodes = null;
+            JsonObject eventNodes = null;
+            if (bodyJson.get(MSG_PARAMS) != null && bodyJson.get(EVENT_PARAMS) != null
+                    && bodyJson.get(MSG_PARAMS).getAsJsonObject().get(META) != null) {
+                msgNodes = bodyJson.get(MSG_PARAMS).getAsJsonObject();
+                eventNodes = bodyJson.get(EVENT_PARAMS).getAsJsonObject();
+            } else {
+                String Message = "Missing fields found in body JSON";
+                String Cause = "eventParams or msgParams or msgParams.meta are missed";
+                log.error(Message + "\nCause: " + Cause);
+                return createErrorResponse(Message, Cause);
+            }
 
             // Compare the input JSON EventType with query parameter(-t) and
             // also
@@ -226,6 +236,7 @@ public String generateMsg(String msgType, JsonObject bodyJson) {
             String result = gson.toJson(event);
             outputValidate(eiffelType, result);
             return result;
+
         } catch (EiffelValidationException e) {
             log.error("Could not validate message. Reason:" + e.getMessage() + "\nCause: " + e.getCause().toString());
             return createErrorResponse(e.getMessage(), e.getCause().toString());
@@ -235,7 +246,6 @@ public String generateMsg(String msgType, JsonObject bodyJson) {
             return createErrorResponse("Json Syntax exception occured while processing input schema",
                     e.getCause().toString());
         }
-
     }
 
     private static Event eventCreation(Class<? extends Event> eventType, JsonObject msgNodes, JsonObject eventNodes) {