Skip to content

Commit ff8892e

Browse files
committed
fix(nodeenv): replace leftover debug print with logger.debug
The debug print in _get_last_node_version() leaked a dict to stdout on every version detection (default run, --node=latest, --node=lts), which breaks output formatting for tools wrapping nodeenv. fixes #390
1 parent d1a89c4 commit ff8892e

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

nodeenv.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1058,7 +1058,9 @@ def _get_last_node_version(lts=False):
10581058
"""
10591059
Return last node.js version matching the filter
10601060
"""
1061-
print({"x86": is_x86_64_musl(), "risc": is_riscv64(), "lts": lts})
1061+
logger.debug(
1062+
' * Host platform: x86_64-musl=%s, riscv64=%s, lts=%s',
1063+
is_x86_64_musl(), is_riscv64(), lts)
10621064

10631065
def version_filter(v):
10641066
if lts and not v['lts']:

tests/nodeenv_test.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,12 @@ def test_get_lts_node_version_riscv64():
190190
assert nodeenv.get_last_lts_node_version() == '12.13.1'
191191

192192

193+
@pytest.mark.usefixtures('mock_index_json', 'mock_host_platform')
194+
def test_get_last_node_version_writes_nothing_to_stdout(capsys):
195+
nodeenv.get_last_stable_node_version()
196+
assert capsys.readouterr().out == ''
197+
198+
193199
def test__download_node_file():
194200
with mock.patch.object(nodeenv, 'urlopen') as m_urlopen:
195201
m_urlopen.side_effect = IncompleteRead("dummy")

0 commit comments

Comments
 (0)