Add attribution

[bmoren]

https://github.com/bmoren/node-omxplayer-sync/blob/master/LICENSE

[elalemanyo]

@bmoren Sorry I forget to set the license, but I was not finish...
I think is maybe better if I remove this repo and just do a fork from your project, because what I did is just add IP als parameter and update some dependencies. Should I just do some PR to your repo?
I hope you are not upset and thanks for you amazing repo. BTW I would like to speak with you about it because I am going to use it for an exhibition and would love to know more about your experience.

Thanks!

[bmoren]

It's no problem, not upset :) Just want to make sure there is a callback to the original repo or that things like the readme, etc come along for the ride.

If you're just changing some ip addresses for your own project the best path is likely to fork the original repo and then make the changes you need to that fork. No need to make a PR unless you're making substantive changes, adding features, or fixing bugs to the original repo.

Happy to answer any questions you have about using it in exhibition context. I've done so many times for months and never had a major issue beyond a system reboot which can easily be done on a schedule if installed cleverly.

b.

[elalemanyo]

ok, thanks for the info.
How is the performance running with wifi? sync works good? that is the fear right now.

[bmoren]

Wifi performance is no problem at all. It's only sending the very minimal socket messages over the network so it's really not much to handle. I've never had an issue with sync. That said, if you are looking for exact frame accurate sync, then this project's strategy generally isnt going to get your there since it's really only about syncing playback and if you have a video that drops a frame, or is encoded slightly differently, or have a pi that slows playback down for some reason, this system will not correct until the video loops which could be an issue if you've got a really long file.

Although again, I must admit that I've never had an issue with this at all. My general files are somewhere between 5-25 minutes and I've never had so much as a frame off, even over wifi.

[elalemanyo]

ok, thanks for your information. Right now I am trying your code but doing some updates (c282d66) and I also add IP als parameter (

socketio_omxplayer_sync/omx-sync.js

Line 3 in c282d66

var ip = process.argv.slice(2)[0]; //get ip

)
I would also try to make possible to ssh the pi when already running... any idea? Why do you use forever and not pm2?

[bmoren]

I would also try to make possible to ssh the pi when already running... any idea?

This is the same issue that I explained in the main repo, when you ssh in because the script is set to auto boot, you start another copy. use forever list and forever stop to stop the second copy and it'll continue to work fine with the first.

Why do you use forever and not pm2?

mostly because when I started this project forever was a more complete, easier to use, direct project than pm2. but feel free to switch to pm2, it's just the process manager so it shouldn't have any effect on the performance of the script.