Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Creating New Terms via CLI #4566

Open
eric-forte-elastic opened this issue Mar 26, 2025 · 0 comments · May be fixed by #4567
Open

[Bug] Creating New Terms via CLI #4566

eric-forte-elastic opened this issue Mar 26, 2025 · 0 comments · May be fixed by #4567
Assignees
Labels
bug Something isn't working Team: TRADE

Comments

@eric-forte-elastic
Copy link
Contributor

Describe the Bug

Summary

Creating a new terms rule via the CLI will currently not prompt the user to supply the new_terms field(s) preventing the user from being able to create the rule.

(See gif for details)

To Reproduce

  1. Run python -m detection_rules create-rule
  2. Choose new-terms
  3. Attempt to complete rule
  4. See error

Expected Behavior

Rule should be created successfully.

Screenshots

Image

Desktop - OS

None

Desktop - Version

No response

Additional Context

At a minimum changing line 188 of detection_rules/cli_utils.py result["value"] = schema_prompt("new_terms_fields", value=kwargs.pop("new_terms_fields")) to result["value"] = schema_prompt("new_terms_fields", value=kwargs.pop("new_terms_fields", None)) will resolve the initial issue of the lack of prompt for new_terms fields, but I expect more changes will be needed to fix the issue.

@eric-forte-elastic eric-forte-elastic added bug Something isn't working Team: TRADE labels Mar 26, 2025
@eric-forte-elastic eric-forte-elastic linked a pull request Mar 26, 2025 that will close this issue
5 tasks
@eric-forte-elastic eric-forte-elastic self-assigned this Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team: TRADE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant