Potential fix for pull request finding 'Nested 'if' statements can be combined'

lcawl · github-code-quality[bot] · web-flow · commit 0b1054dd0015 · 2025-12-03T16:17:42.000-08:00
Co-authored-by: Copilot Autofix powered by AI &lt;223894421+github-code-quality[bot]@users.noreply.github.com&gt;
diff --git a/src/services/Elastic.Documentation.Services/ReleaseNotesService.cs b/src/services/Elastic.Documentation.Services/ReleaseNotesService.cs
@@ -67,13 +67,10 @@ Cancel ctx
 			}
 
 			// Validate subtype if provided
-			if (!string.IsNullOrWhiteSpace(input.Subtype))
+			if (!string.IsNullOrWhiteSpace(input.Subtype) && !config.AvailableSubtypes.Contains(input.Subtype))
 			{
-				if (!config.AvailableSubtypes.Contains(input.Subtype))
-				{
-					collector.EmitError(string.Empty, $"Subtype '{input.Subtype}' is not in the list of available subtypes. Available subtypes: {string.Join(", ", config.AvailableSubtypes)}");
-					return false;
-				}
+				collector.EmitError(string.Empty, $"Subtype '{input.Subtype}' is not in the list of available subtypes. Available subtypes: {string.Join(", ", config.AvailableSubtypes)}");
+				return false;
 			}
 
 			// Validate areas if configuration provides available areas

Original file line number	Diff line number	Diff line change
`@@ -67,13 +67,10 @@ Cancel ctx`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`// Validate subtype if provided`
`70`		`- if (!string.IsNullOrWhiteSpace(input.Subtype))`
	`70`	`+ if (!string.IsNullOrWhiteSpace(input.Subtype) && !config.AvailableSubtypes.Contains(input.Subtype))`
`71`	`71`	`{`
`72`		`- if (!config.AvailableSubtypes.Contains(input.Subtype))`
`73`		`- {`
`74`		`- collector.EmitError(string.Empty, $"Subtype '{input.Subtype}' is not in the list of available subtypes. Available subtypes: {string.Join(", ", config.AvailableSubtypes)}");`
`75`		`- return false;`
`76`		`- }`
	`72`	`+ collector.EmitError(string.Empty, $"Subtype '{input.Subtype}' is not in the list of available subtypes. Available subtypes: {string.Join(", ", config.AvailableSubtypes)}");`
	`73`	`+ return false;`
`77`	`74`	`}`
`78`	`75`
`79`	`76`	`// Validate areas if configuration provides available areas`