Remove the behaviour where AskAI is triggered if there are no results

Author: reakaleek

src/Elastic.Documentation.Site/Assets/web-components/SearchOrAskAi/Search/Search.tsx

@@ -47,7 +47,10 @@ export const Search = () => {
     }
 
     const { inputRef, buttonRef, itemRefs, filterRefs, handleInputKeyDown } =
-        useSearchKeyboardNavigation(resultsCount)
+        useSearchKeyboardNavigation({
+            resultsCount,
+            isLoading: isLoading || isFetching,
+        })
 
     // Listen for Cmd+K to focus input
     useEffect(() => {

src/Elastic.Documentation.Site/Assets/web-components/SearchOrAskAi/Search/useSearchKeyboardNavigation.ts

@@ -1,7 +1,11 @@
 import { useSelectedIndex, useSearchActions } from './search.store'
-import { useAskAiFromSearch } from './useAskAiFromSearch'
 import { useRef, useCallback, MutableRefObject } from 'react'
 
+interface SearchKeyboardNavigationOptions {
+    resultsCount: number
+    isLoading: boolean
+}
+
 interface SearchKeyboardNavigationReturn {
     inputRef: React.RefObject<HTMLInputElement>
     buttonRef: React.RefObject<HTMLButtonElement>
@@ -10,30 +14,31 @@ interface SearchKeyboardNavigationReturn {
     handleInputKeyDown: (e: React.KeyboardEvent<HTMLInputElement>) => void
 }
 
-export const useSearchKeyboardNavigation = (
-    resultsCount: number
-): SearchKeyboardNavigationReturn => {
+export const useSearchKeyboardNavigation = ({
+    resultsCount,
+    isLoading,
+}: SearchKeyboardNavigationOptions): SearchKeyboardNavigationReturn => {
     const inputRef = useRef<HTMLInputElement>(null)
     const buttonRef = useRef<HTMLButtonElement>(null)
     const itemRefs = useRef<(HTMLAnchorElement | null)[]>([])
     const filterRefs = useRef<(HTMLButtonElement | null)[]>([])
-    const { askAi } = useAskAiFromSearch()
     const selectedIndex = useSelectedIndex()
     const { setSelectedIndex } = useSearchActions()
 
     const handleInputKeyDown = useCallback(
         (e: React.KeyboardEvent<HTMLInputElement>) => {
             if (e.key === 'Enter') {
                 e.preventDefault()
-                if (resultsCount > 0 && selectedIndex >= 0) {
+                if (isLoading || resultsCount === 0) {
+                    // Don't do anything while search is loading or if there are no results
+                    return
+                }
+                if (selectedIndex >= 0) {
                     // Navigate to selected result
                     itemRefs.current[selectedIndex]?.click()
-                } else if (resultsCount > 0) {
+                } else {
                     // No selection, click first result
                     itemRefs.current[0]?.click()
-                } else {
-                    // No results, ask AI
-                    askAi()
                 }
             } else if (e.key === 'ArrowDown') {
                 e.preventDefault()
@@ -71,7 +76,7 @@ export const useSearchKeyboardNavigation = (
             }
             // Tab works naturally - goes to filters, then button
         },
-        [resultsCount, selectedIndex, setSelectedIndex, askAi]
+        [resultsCount, isLoading, selectedIndex, setSelectedIndex]
     )
 
     return {