Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGS that are autogenerated for the ES|QL docs are being improperly displayed #567

Open
3 tasks
georgewallace opened this issue Feb 20, 2025 · 4 comments
Open
3 tasks
Labels
authoring Relates to our markdown parser bug

Comments

@georgewallace
Copy link
Contributor

Describe the bug

SVGs from the ES|QL sections are showing up all black. Image. They are generated by the following code. https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/RailRoadDiagram.java.

Nik Everett thinks that the following is what might be breaking it. https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/RailRoadDiagram.java#L129.

He states that "we need the font during the build because we need to size the image. which is annoying, but it's thing"

Expected behavior

We expect the SVGS to show like: Image

Steps to reproduce

locally build the ES|QL docs and view any of the functions or commands pages.

Tooling

  • docs-builder
  • migration tooling
  • I'm not sure
@georgewallace
Copy link
Contributor Author

On the existing docs site it looks like we don't embed the SVGs and we style the class appropriately.

Image Image

@bmorelli25 bmorelli25 added the authoring Relates to our markdown parser label Feb 20, 2025
@bmorelli25
Copy link
Member

Could these be mermaid instead?

@bmorelli25
Copy link
Member

Potentially fixed by https://github.com/elastic/asciidocalypse/pull/109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authoring Relates to our markdown parser bug
Projects
None yet
Development

No branches or pull requests

2 participants