Skip to content

Conversation

@georgewallace
Copy link
Contributor

AI-Assisted: This PR was assisted by Cursor.
Usage: styled and validated missing changes

@github-actions
Copy link

@georgewallace
Copy link
Contributor Author

Need review for Security team (ES)

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Overall the AI seems not to be very consistent at hitting the mark for our standard format/style guide. I wonder if we can iterate on the prompt, because it's great to document these issues.

@georgewallace , I'm curious about your thoughts on the tradeoff between consistent quality of the writing, vs. documenting all these changes that were previously missing.

* Filters endpoint exceptions from the detection engine's execution logic. For more information, check [#233289]({{kib-pull}}233289).

## August 25, 2025 [elastic-cloud-serverless-08252025-deprecations]
* Changes `reporting_user` role to leverage reserved Kibana privileges. For more information, check [#132766]({{kib-pull}}132766).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Changes `reporting_user` role to leverage reserved Kibana privileges. For more information, check [#132766]({{kib-pull}}132766).
* Changes `reporting_user` role to leverage reserved {{kib}} privileges. For more information, check [#132766]({{kib-pull}}132766).

* Ensures only valid queries are returned for significant events [#239501]({{kib-pull}}239501)
* Hides filtering capabilities in Hosts Metrics [#239724]({{kib-pull}}239724)

* Configurable HTTP read and connect timeouts for url based SAML metadata resolution [#136058](https://github.com/elastic/elasticsearch/pull/136058)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Configurable HTTP read and connect timeouts for url based SAML metadata resolution [#136058](https://github.com/elastic/elasticsearch/pull/136058)
* Adds configurable HTTP read and connect timeouts for URL-based SAML metadata resolution [#136058](https://github.com/elastic/elasticsearch/pull/136058)

* Removes the global empty state redirect [#237612]({{kib-pull}}237612)
* Replaces the existing document count chart with RED metrics [#236635]({{kib-pull}}236635)

* Sends cross cluster api key signature as header [#135674](https://github.com/elastic/elasticsearch/pull/135674)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Sends cross cluster api key signature as header [#135674](https://github.com/elastic/elasticsearch/pull/135674)
* Sends cross cluster API key signature as header [#135674](https://github.com/elastic/elasticsearch/pull/135674)

* Adds **View in discover** button in alert details page for SLO burn rate and ES query rules [#233855]({{kib-pull}}233855)

* Adds reload listener to SslProfile [#135244](https://github.com/elastic/elasticsearch/pull/135244)
* Adds DLS stats to ``_security`/stats` [#135271](https://github.com/elastic/elasticsearch/pull/135271)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Adds DLS stats to ``_security`/stats` [#135271](https://github.com/elastic/elasticsearch/pull/135271)
* Adds DLS stats to `_security/stats` [#135271](https://github.com/elastic/elasticsearch/pull/135271)

Not 100% about this but the format looked off


* Adds reload listener to SslProfile [#135244](https://github.com/elastic/elasticsearch/pull/135244)
* Adds DLS stats to ``_security`/stats` [#135271](https://github.com/elastic/elasticsearch/pull/135271)
* Adds trust configuration for cross cluster api keys [#134893](https://github.com/elastic/elasticsearch/pull/134893)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Adds trust configuration for cross cluster api keys [#134893](https://github.com/elastic/elasticsearch/pull/134893)
* Adds trust configuration for cross cluster API keys [#134893](https://github.com/elastic/elasticsearch/pull/134893)


* Fixes unsupported privileges error message during role and API key crea… [#128858](https://github.com/elastic/elasticsearch/pull/128858)
* Adds transport version support for IDP_CUSTOM_SAML_ATTRIBUTES_ADDED_8_19 [#128798](https://github.com/elastic/elasticsearch/pull/128798)
* Granting `kibana_system` reserved role access to "all" privileges to `.adhoc.alerts*` and `.internal.adhoc.alerts*` indices [#127321](https://github.com/elastic/elasticsearch/pull/127321)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Granting `kibana_system` reserved role access to "all" privileges to `.adhoc.alerts*` and `.internal.adhoc.alerts*` indices [#127321](https://github.com/elastic/elasticsearch/pull/127321)
* Grants `kibana_system` reserved role access to "all" privileges to `.adhoc.alerts*` and `.internal.adhoc.alerts*` indices [#127321](https://github.com/elastic/elasticsearch/pull/127321)

* Enables full-text search in `STATS ... WHERE` **ES|QL** queries [#220691]({{kib-pull}}220691)
* Prevents downloading trained models that are already present in other spaces and displays a warning in Machine Learning [#220238]({{kib-pull}}220238)

* Adds Microsoft Graph Delegated Authorization Realm Plugin [#127910](https://github.com/elastic/elasticsearch/pull/127910)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Adds Microsoft Graph Delegated Authorization Realm Plugin [#127910](https://github.com/elastic/elasticsearch/pull/127910)
* Adds Microsoft Graph Delegated Authorization Realm plugin [#127910](https://github.com/elastic/elasticsearch/pull/127910)

* Allows you to customize the table tab [#218686](https://github.com/elastic/kibana/pull/218686)
* Enables keyboard navigation for the create annotations form [#217918](https://github.com/elastic/kibana/pull/217918)

* [Security Solution] Add `read` index privileges to `kibana_system` role for Microsoft Defender integration indexes [#126803](https://github.com/elastic/elasticsearch/pull/126803)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Security Solution] Add `read` index privileges to `kibana_system` role for Microsoft Defender integration indexes [#126803](https://github.com/elastic/elasticsearch/pull/126803)
* Adds `read` index privileges to `kibana_system` role for Microsoft Defender integration indexes [#126803](https://github.com/elastic/elasticsearch/pull/126803)

* Supports integrations having secrets with multiple values in Fleet [#216918]({{kib-pull}}216918)
* Adds overlay to the add/edit integration page in Fleet [#217151]({{kib-pull}}217151)

* [Failure Store] Authorization denial messages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty hard to figure out what this means with no PR link — I guess it's in a private repo?

* Adds effects when clicking the **Favorite** button in the list of dashboards and {{esql}} queries, and adds the button to breadcrumb trails [#201596]({{kib-pull}}201596)
* Enables `/api/streams/{id}/_group` endpoints for GroupStreams [#210114]({{kib-pull}}210114)

* Do not fetch reserved roles from native store when Get Role API is called [#121971](https://github.com/elastic/elasticsearch/pull/121971)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Do not fetch reserved roles from native store when Get Role API is called [#121971](https://github.com/elastic/elasticsearch/pull/121971)
* Prevents fetching reserved roles from native store when Get Role API is called [#121971](https://github.com/elastic/elasticsearch/pull/121971)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants