Fix serialization performance: properties weren't being added to the property cache after being resolved

gmarz · gmarz · commit 8b50bfbfde55 · 2016-01-06T12:48:29.000-05:00
diff --git a/src/Nest/CommonAbstractions/Extensions/TypeExtensions.cs b/src/Nest/CommonAbstractions/Extensions/TypeExtensions.cs
@@ -121,7 +121,9 @@ internal static IList<JsonProperty> GetCachedObjectProperties(this Type t, Membe
 			if (_cachedTypeProperties.TryGetValue(t, out propertyDictionary))
 				return propertyDictionary;
 
-			return  _jsonContract.PropertiesOfAll(t, memberSerialization);
+			var properties = _jsonContract.PropertiesOfAll(t, memberSerialization);
+			_cachedTypeProperties.TryAdd(t, properties);
+			return properties;
 		}
 
 	}

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,9 @@ internal static IList<JsonProperty> GetCachedObjectProperties(this Type t, Membe`
`121`	`121`	`if (_cachedTypeProperties.TryGetValue(t, out propertyDictionary))`
`122`	`122`	`return propertyDictionary;`
`123`	`123`
`124`		`- return _jsonContract.PropertiesOfAll(t, memberSerialization);`
	`124`	`+ var properties = _jsonContract.PropertiesOfAll(t, memberSerialization);`
	`125`	`+ _cachedTypeProperties.TryAdd(t, properties);`
	`126`	`+ return properties;`
`125`	`127`	`}`
`126`	`128`
`127`	`129`	`}`