Reuse propertyDictionary variable

gmarz · gmarz · commit c0865462f945 · 2016-01-06T12:52:06.000-05:00
diff --git a/src/Nest/CommonAbstractions/Extensions/TypeExtensions.cs b/src/Nest/CommonAbstractions/Extensions/TypeExtensions.cs
@@ -120,11 +120,9 @@ internal static IList<JsonProperty> GetCachedObjectProperties(this Type t, Membe
 			IList<JsonProperty> propertyDictionary;
 			if (_cachedTypeProperties.TryGetValue(t, out propertyDictionary))
 				return propertyDictionary;
-
-			var properties = _jsonContract.PropertiesOfAll(t, memberSerialization);
-			_cachedTypeProperties.TryAdd(t, properties);
-			return properties;
+			propertyDictionary = _jsonContract.PropertiesOfAll(t, memberSerialization);
+			_cachedTypeProperties.TryAdd(t, propertyDictionary);
+			return propertyDictionary;
 		}
-
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -120,11 +120,9 @@ internal static IList<JsonProperty> GetCachedObjectProperties(this Type t, Membe`
`120`	`120`	`IList<JsonProperty> propertyDictionary;`
`121`	`121`	`if (_cachedTypeProperties.TryGetValue(t, out propertyDictionary))`
`122`	`122`	`return propertyDictionary;`
`123`		`-`
`124`		`- var properties = _jsonContract.PropertiesOfAll(t, memberSerialization);`
`125`		`- _cachedTypeProperties.TryAdd(t, properties);`
`126`		`- return properties;`
	`123`	`+ propertyDictionary = _jsonContract.PropertiesOfAll(t, memberSerialization);`
	`124`	`+ _cachedTypeProperties.TryAdd(t, propertyDictionary);`
	`125`	`+ return propertyDictionary;`
`127`	`126`	`}`
`128`		`-`
`129`	`127`	`}`
`130`	`128`	`}`