From 9fec676677e1ba0dfc89b7df12d099b5bca7e319 Mon Sep 17 00:00:00 2001 From: Rocco Stanzione Date: Tue, 15 Mar 2022 15:09:04 -0500 Subject: [PATCH] Improve README suggestion for async indexing with after_save_commit * after_commit solves testing problems by ensuring create is committed * Use rails 6's after_save_commit to avoid reindexing on destroy --- elasticsearch-model/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/elasticsearch-model/README.md b/elasticsearch-model/README.md index a5345b4b9..5da467bcd 100644 --- a/elasticsearch-model/README.md +++ b/elasticsearch-model/README.md @@ -506,8 +506,8 @@ with a tool like [_Resque_](https://github.com/resque/resque) or [_Sidekiq_](htt class Article include Elasticsearch::Model - after_save { Indexer.perform_async(:index, self.id) } - after_destroy { Indexer.perform_async(:delete, self.id) } + after_save_commit { Indexer.perform_async(:index, self.id) } + after_destroy { Indexer.perform_async(:delete, self.id) } end ```