Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup updatecli for oblt-cli version #83

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Setup updatecli for oblt-cli version #83

merged 3 commits into from
Jul 9, 2024

Conversation

reakaleek
Copy link
Member

No description provided.

@reakaleek reakaleek added the changelog:chore When you add a change that is not user-facing label Jul 9, 2024
@reakaleek reakaleek self-assigned this Jul 9, 2024
@reakaleek reakaleek requested a review from a team July 9, 2024 13:31
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to configure this with the list of Repositories that can use it.

@reakaleek reakaleek requested a review from v1v July 9, 2024 13:55
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment to use the default folder

@reakaleek reakaleek merged commit 2b96649 into main Jul 9, 2024
4 checks passed
@reakaleek reakaleek deleted the feature/updatecli branch July 9, 2024 14:02
@reakaleek
Copy link
Member Author

reakaleek commented Jul 9, 2024

LGTM, just a minor comment to use the default folder

Sorry, where is the comment? 😅

default folder for values.d?

@reakaleek
Copy link
Member Author

⬆️ @v1v

@v1v
Copy link
Member

v1v commented Jul 9, 2024

⬆️ @v1v

Ups, I was expecting my comment, maybe I didn't type enter 😢

I was saying that we can use the default updatecli folder structure:

and so on.

It's not what we do in almost all the projects, since .ci was already in place. But we can apply the default for the projects we own, if we prefer

@reakaleek
Copy link
Member Author

Okay. thanks!

⬆️ @v1v

Ups, I was expecting my comment, maybe I didn't type enter 😢

I was saying that we can use the default updatecli folder structure:

and so on.

It's not what we do in almost all the projects, since .ci was already in place. But we can apply the default for the projects we own, if we prefer

Okay thanks.. will definitely do in a follow-up.

@reakaleek
Copy link
Member Author

reakaleek commented Jul 9, 2024

Okay. thanks!

⬆️ @v1v

Ups, I was expecting my comment, maybe I didn't type enter 😢
I was saying that we can use the default updatecli folder structure:

and so on.
It's not what we do in almost all the projects, since .ci was already in place. But we can apply the default for the projects we own, if we prefer

Okay thanks.. will definitely do in a follow-up.

@v1v I'm actually afraid this could be confusing in this repo.

the updatecli folder is the tool action folder. I'm afraid that it could be confused to be part of the action instead of the repository? WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:chore When you add a change that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants