Fix joining a room twice

[matrixbot]

This issue was originally created by @kegsay at matrix-org/dendrite#1311.

Sytests:

    × Joining room twice is idempotent

[matrixbot]

This comment was originally posted by @Tert0 at matrix-org/dendrite#1311 (comment).

I get

Test 138 Joining room twice is idempotent... EXPECTED FAIL

as output for SyTests.

Does that mean that it works?

[matrixbot]

This comment was originally posted by @kegsay at matrix-org/dendrite#1311 (comment).

No, it should be ... OK

[matrixbot]

This comment was originally posted by @ZofiaZementa at matrix-org/dendrite#1311 (comment).

@Tert0 are you working on this? Otherwise I'd like to take a swing at it
Edit: Nvm, just saw above that this seems to be an issue with the tests, I don't think i know enough to fix that

[matrixbot]

This comment was originally posted by @nicobao at matrix-org/dendrite#1311 (comment).

Hi,
I am looking at it.

[matrixbot]

This comment was originally posted by @kegsay at matrix-org/dendrite#1311 (comment).

Still failing as of today.

[matrixbot]

This comment was originally posted by @nicobao at matrix-org/dendrite#1311 (comment).

Still failing as of today.

I had started and struggled at logging the relevant logs from the Perl fixture. I tried to figure out what part of the Go code was called.
Then, for some reason I thought I received a notification that someone had fixed it that's why I didn't update my previous post. My apologies for misleading you that I would fix the issue. Unfortunately, I won't have time to go further for a while, I am overwhelmed with work. So if anyone wants, please do go ahead and fix this issue.

[matrixbot]

This comment was originally posted by @S7evinK at matrix-org/dendrite#1311 (comment).

Fixed in matrix-org/dendrite#2512 or rather in matrix-org/sytest#1256