Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion method should return the converted data, and rely on another method to write data onto a file #20

Open
rhdolin opened this issue Dec 8, 2020 · 3 comments
Labels
defer This issue has dependencies and shouldn't yet be tackled.

Comments

@rhdolin
Copy link
Contributor

rhdolin commented Dec 8, 2020

Currently vcf2fhir converts and exports the HL7 FHIR format data to a json file. The converted json data for all the records exists in memory till it is exported in the end.

Evaluation Required:
In memory storage required for FHIR json in case of very big VCF file conversion.

VCF files are sometimes expected to be in the size of GB's, it is better to write the converted FHIR json format for each record to file instead of in memory before moving to the next record. Major complexity in doing this is handling phase relationship json blocks which spans across multiple records.

Other Options:

  1. Throw Exception if In memory json blob reaches near maximum capacity allowed by system instead of Heap dump.
  2. Update the Readme file to notify used to provide the conversion region which converts only limited records in case of very big VCF file.
@theanmolsharma
Copy link
Contributor

I would like to work on this issue. Please guide me through it.

@srgothi92
Copy link
Contributor

This particular issue would require lots of understanding and design before moving to implementation. Personally, in my opinion we would not like to fix this unless someone really wants it.

@theanmolsharma
Copy link
Contributor

Okay. I will work on some other beginner-friendly issue.

@rhdolin rhdolin added the defer This issue has dependencies and shouldn't yet be tackled. label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defer This issue has dependencies and shouldn't yet be tackled.
Projects
None yet
Development

No branches or pull requests

3 participants