Skip to content

jupyter-repl-mode chokes if yank-excluded-properties is not a list #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcmillanbb opened this issue Mar 16, 2025 · 4 comments
Open

Comments

@mcmillanbb
Copy link

In the setup for jupyter repl mode, there is a call to remq on yank-excluded-properties.
This assumes that yank-excluded-properties is a list. However, the variable yank-excluded-properties allows for the value of t, in which case jupyter repl mode cannot start up.

It should be a minor fix, simply wrapping the call in a check that yank-excluded-properties is a list.
If that makes sense, I am happy to submit a pull request.

@nnicandro
Copy link
Collaborator

nnicandro commented Mar 16, 2025

Sounds good,for the case of t just (and yank-excluded-properties nil) should be good enough.

@mcmillanbb
Copy link
Author

I'm sorry, I don't quite understand your comment, can you expand a little?

@tgbugs
Copy link
Contributor

tgbugs commented Mar 20, 2025

See #408

@mcmillanbb
Copy link
Author

Ah, thanks for pointing that out! I thought I had searched for the issue, but must have missed yours.
Your PR would would work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants