fix: address lint warnings detected by ts_query_ls #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit address various lints like duplicate alternants in alternations, superfluous escape chars (`\`), and unused underscored captures. Please let me know if you'd like a workflow to detect this in CI, and/or one to ensure queries have been formatted with `ts_query_ls`. I'd be happy to do this.
Author
|
By the way @jcs090218, this check can be performed regardless of whether parser objects are installed :) But a deeper analysis can be performed with them. (Though you may likely already have such a check for this repo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit address various lints like duplicate alternants in alternations, superfluous escape chars (
\), and unused underscored captures.Please let me know if you'd like a workflow to detect this in CI, and/or one to ensure queries have been formatted with
ts_query_ls. I'd be happy to do this.