Merge pull request robotframework#1931 from emanlove/downgrade-click-version

Downgrade click version

Author: emanlove

.github/workflows/CI.yml

@@ -87,8 +87,9 @@ jobs:
     #     sudo chmod u+x ./selenium-server-standalone.jar
     #     xvfb-run --auto-servernum python atest/run.py --zip headlesschrome  --grid True
 
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       if: failure()
       with:
         name: SeleniumLibrary Test results
         path: atest/zip_results
+        overwrite: true

atest/acceptance/locators/custom.robot

@@ -55,4 +55,4 @@ Teardown Custom Locator
 Custom Locator Strategy
     [Arguments]    ${browser}    ${locator}    ${tag}    ${constraints}
     ${element}=    Execute Javascript    return window.document.getElementById('${locator}') || [];
-    [Return]    ${element}
+    RETURN    ${element}

atest/acceptance/resource.robot

@@ -24,7 +24,7 @@ Open Browser To Start Page Without Testing Default Options
     ...    desired_capabilities=${DESIRED_CAPABILITIES}    alias=${alias}
     ${orig speed} =    Set Selenium Speed    ${SPEED}
     ${orig timeout} =    Set Selenium Timeout    10 seconds
-    [Return]    ${orig speed}    5 seconds
+    RETURN    ${orig speed}    5 seconds
 
 Cannot Be Executed In IE
     [Documentation]    Cannot Be Executed In IE

atest/run.py

@@ -251,7 +251,7 @@ def process_output(browser):
     print("Verifying results...")
     options = []
     output = os.path.join(RESULTS_DIR, "output.xml")
-    robotstatuschecker.process_output(output, verbose=False)
+    robotstatuschecker.process_output(output)
     options.extend([opt.format(browser=browser) for opt in REBOT_OPTIONS])
     try:
         rebot_cli(options + [output])

requirements.txt

@@ -1,4 +1,4 @@
 selenium >= 4.3.0
 robotframework >= 4.1.3
 robotframework-pythonlibcore >= 4.4.1
-click >= 8.1.7
+click >= 8.0

src/SeleniumLibrary/__init__.py

@@ -238,7 +238,7 @@ class SeleniumLibrary(DynamicCore):
 
     | Custom Locator Strategy | [Arguments] | ${browser} | ${locator} | ${tag} | ${constraints} |
     |   | ${element}= | Execute Javascript | return window.document.getElementById('${locator}'); |
-    |   | [Return] | ${element} |
+    |   | RETURN | ${element} |
 
     This keyword is a reimplementation of the basic functionality of the
     ``id`` locator where ``${browser}`` is a reference to a WebDriver

utest/test/api/approved_files/PluginDocumentation.test_many_plugins.approved.txt

@@ -177,7 +177,7 @@ a WebElement that should be acted on:
 
 | Custom Locator Strategy | [Arguments] | ${browser} | ${locator} | ${tag} | ${constraints} |
 |   | ${element}= | Execute Javascript | return window.document.getElementById('${locator}'); |
-|   | [Return] | ${element} |
+|   | RETURN | ${element} |
 
 This keyword is a reimplementation of the basic functionality of the
 ``id`` locator where ``${browser}`` is a reference to a WebDriver