Skip to content

Commit bbfb786

Browse files
Merge #1064
1064: Fix LoRaWAN PHY settings for SX126x driver r=Dirbaio a=jbeaurivage While working on #1023 / #1041, I noticed that the `lorawan_device::PhyTxRx` implementation does not conform to the LoRaWAN standard, and therefore devices using this driver could never communicate with a gateway. This PR backports the changes I've made to fix the offending parameters, and I can confirm that the driver now works with LoRaWAN networks. * Set preamble length to 8 symbols * Set polarity to inverted for received messages Co-authored-by: Justin Beaurivage <[email protected]>
2 parents 2528f45 + 81dc532 commit bbfb786

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

embassy-lora/src/sx126x/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ where
8787
config.rf.spreading_factor.into(),
8888
config.rf.bandwidth.into(),
8989
config.rf.coding_rate.into(),
90-
4,
90+
8,
9191
false,
9292
true,
9393
false,
@@ -119,14 +119,14 @@ where
119119
config.spreading_factor.into(),
120120
config.bandwidth.into(),
121121
config.coding_rate.into(),
122-
4,
122+
8,
123123
4,
124124
false,
125125
0u8,
126126
true,
127127
false,
128128
0,
129-
false,
129+
true,
130130
true,
131131
)
132132
.await?;

0 commit comments

Comments
 (0)