Skip to content

Extract rule: no-invalid-aria-attributes #4160

Extract rule: no-invalid-aria-attributes

Extract rule: no-invalid-aria-attributes #4160

Status Failure
Total duration 1m 20s
Artifacts

ci.yml

on: pull_request
self-lint
56s
self-lint
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

15 errors
self-lint
Process completed with exit code 1.
build (ubuntu, 20.x)
Process completed with exit code 1.
tests/rule-setup.js > rules setup is correct > should mention all rules in the README: tests/rule-setup.js#L81
AssertionError: expected '# eslint-plugin-ember\n\n[![NPM versi…' to contain 'template-no-invalid-aria-attributes' - Expected + Received - template-no-invalid-aria-attributes + # eslint-plugin-ember + + [![NPM version](https://img.shields.io/npm/v/eslint-plugin-ember.svg?style=flat)](https://npmjs.org/package/eslint-plugin-ember) + [![NPM downloads](https://img.shields.io/npm/dm/eslint-plugin-ember.svg?style=flat)](https://npmjs.org/package/eslint-plugin-ember) + ![CI](https://github.com/ember-cli/eslint-plugin-ember/workflows/CI/badge.svg) + + > An ESLint plugin that provides a set of rules for Ember applications based on commonly known good practices. + + ## ❗️Requirements + + - [ESLint](https://eslint.org/) `>= 8` + - [Node.js](https://nodejs.org/) `18.* || 20.* || >= 21` + + ## 🚀 Usage + + ### 1. Install plugin + + ```shell + npm install --save-dev eslint-plugin-ember + ``` + + ### 2. Update your config + + ```js + // eslint.config.js (flat config) + const eslintPluginEmberRecommended = require('eslint-plugin-ember/configs/recommended'); + + module.exports = [ + ...eslintPluginEmberRecommended, + ]; + ``` + + or + + ```js + // .eslintrc.js (legacy config) + module.exports = { + plugins: ['ember'], + extends: [ + 'eslint:recommended', + 'plugin:ember/recommended' // or other configuration + ], + rules: { + // override / enable optional rules + 'ember/no-replace-test-comments': 'error' + } + }; + ``` + + ## gts/gjs + + lint files having `First-Class Component Templates` (fcct) + + learn more [here](https://github.com/ember-template-imports/ember-template-imports) + + > [!NOTE] + > special care should be used when setting up parsers, since they cannot be overwritten. thus they should be used in override only and specific to file types + + gjs/gts support is provided by the [ember-eslint-parser](https://github.com/NullVoxPopuli/ember-eslint-parser) + + > [!NOTE] + > if you import .gts files in .ts files, then `ember-eslint-parser` is required for .ts as well to enable typed linting + + ```js + // .eslintrc.js + module.exports = { + overrides: [ + { + files: ['**/*.{js,ts}'], + plugins: ['ember'], + parser: '@typescript-eslint/parser', + extends: [ + 'eslint:recommended', + 'plugin:ember/recommended', // or other configuration + ], + rules: { + // override / enable optional rules + 'ember/no-replace-test-comments': 'error' + } + }, + { + files: ['**/*.gts'], + parser: 'ember-eslint-parser', + plugins: ['ember'], + extends: [ + 'eslint:recommended', + 'plugin:@typescript-eslint/recommended', + 'plugin:ember/recommended', + 'plugin:ember/recommended-gts', + ], + }, + { + files: ['**/*.gjs'], + parser: 'ember-eslint-parser', + plugins: ['ember'], + extends: [ + 'eslint:recommended', + 'plugin:ember/recommended', + 'plugin:ember/recommended-gjs', + ], + }, + { + files: ['tests/**/*.{js,ts,gjs,gts}'], + rules: { + // override / enable optional rules + 'ember/no-replace-test-comments': 'error' + } + }, + ], + }; + ``` + + ### rules applied to fcct templates + + - semi rule, same as [prettier plugin](https://github.com/gitKrystan/prettier-plugin-ember-template-tag/issues/1) + - no-undef rule will take effect for template vars (includes js scope) + - no-unused rule will take effect for template block params + + rules in templates can be disabled with eslint directives with mustache or html comments: + + ```hbs + <template> + <div> + {{!eslint-disable-next-line}} + {{test}} + </div> + <div> + {{!--eslint-disable--}} + {{test}} + {{test}} + {{test}} + {{!--eslint-enable--}} + </div> + </template> + ``` + + ```hbs + <template> + <div> + <!--eslint-disable-next-line--> + {{test}} + </div> + <div> + <!-- eslint-disable --> + {{test}} + {{test}} + {{test}} + <!-- eslint-ena
build (ubuntu, 22.x)
The strategy configuration was canceled because "build.ubuntu_20_x" failed
build (ubuntu, 22.x)
Process completed with exit code 1.
tests/rule-setup.js > rules setup is correct > should mention all rules in the README: tests/rule-setup.js#L81
AssertionError: expected '# eslint-plugin-ember\n\n[![NPM versi…' to contain 'template-no-invalid-aria-attributes' - Expected + Received - template-no-invalid-aria-attributes + # eslint-plugin-ember + + [![NPM version](https://img.shields.io/npm/v/eslint-plugin-ember.svg?style=flat)](https://npmjs.org/package/eslint-plugin-ember) + [![NPM downloads](https://img.shields.io/npm/dm/eslint-plugin-ember.svg?style=flat)](https://npmjs.org/package/eslint-plugin-ember) + ![CI](https://github.com/ember-cli/eslint-plugin-ember/workflows/CI/badge.svg) + + > An ESLint plugin that provides a set of rules for Ember applications based on commonly known good practices. + + ## ❗️Requirements + + - [ESLint](https://eslint.org/) `>= 8` + - [Node.js](https://nodejs.org/) `18.* || 20.* || >= 21` + + ## 🚀 Usage + + ### 1. Install plugin + + ```shell + npm install --save-dev eslint-plugin-ember + ``` + + ### 2. Update your config + + ```js + // eslint.config.js (flat config) + const eslintPluginEmberRecommended = require('eslint-plugin-ember/configs/recommended'); + + module.exports = [ + ...eslintPluginEmberRecommended, + ]; + ``` + + or + + ```js + // .eslintrc.js (legacy config) + module.exports = { + plugins: ['ember'], + extends: [ + 'eslint:recommended', + 'plugin:ember/recommended' // or other configuration + ], + rules: { + // override / enable optional rules + 'ember/no-replace-test-comments': 'error' + } + }; + ``` + + ## gts/gjs + + lint files having `First-Class Component Templates` (fcct) + + learn more [here](https://github.com/ember-template-imports/ember-template-imports) + + > [!NOTE] + > special care should be used when setting up parsers, since they cannot be overwritten. thus they should be used in override only and specific to file types + + gjs/gts support is provided by the [ember-eslint-parser](https://github.com/NullVoxPopuli/ember-eslint-parser) + + > [!NOTE] + > if you import .gts files in .ts files, then `ember-eslint-parser` is required for .ts as well to enable typed linting + + ```js + // .eslintrc.js + module.exports = { + overrides: [ + { + files: ['**/*.{js,ts}'], + plugins: ['ember'], + parser: '@typescript-eslint/parser', + extends: [ + 'eslint:recommended', + 'plugin:ember/recommended', // or other configuration + ], + rules: { + // override / enable optional rules + 'ember/no-replace-test-comments': 'error' + } + }, + { + files: ['**/*.gts'], + parser: 'ember-eslint-parser', + plugins: ['ember'], + extends: [ + 'eslint:recommended', + 'plugin:@typescript-eslint/recommended', + 'plugin:ember/recommended', + 'plugin:ember/recommended-gts', + ], + }, + { + files: ['**/*.gjs'], + parser: 'ember-eslint-parser', + plugins: ['ember'], + extends: [ + 'eslint:recommended', + 'plugin:ember/recommended', + 'plugin:ember/recommended-gjs', + ], + }, + { + files: ['tests/**/*.{js,ts,gjs,gts}'], + rules: { + // override / enable optional rules + 'ember/no-replace-test-comments': 'error' + } + }, + ], + }; + ``` + + ### rules applied to fcct templates + + - semi rule, same as [prettier plugin](https://github.com/gitKrystan/prettier-plugin-ember-template-tag/issues/1) + - no-undef rule will take effect for template vars (includes js scope) + - no-unused rule will take effect for template block params + + rules in templates can be disabled with eslint directives with mustache or html comments: + + ```hbs + <template> + <div> + {{!eslint-disable-next-line}} + {{test}} + </div> + <div> + {{!--eslint-disable--}} + {{test}} + {{test}} + {{test}} + {{!--eslint-enable--}} + </div> + </template> + ``` + + ```hbs + <template> + <div> + <!--eslint-disable-next-line--> + {{test}} + </div> + <div> + <!-- eslint-disable --> + {{test}} + {{test}} + {{test}} + <!-- eslint-ena
build (windows, 22.x)
The strategy configuration was canceled because "build.ubuntu_20_x" failed
build (windows, 22.x)
The operation was canceled.
build (windows, 20.x)
The strategy configuration was canceled because "build.ubuntu_20_x" failed
build (windows, 20.x)
The operation was canceled.
build (windows, 18.x)
The strategy configuration was canceled because "build.ubuntu_20_x" failed
build (windows, 18.x)
The operation was canceled.
build (ubuntu, 18.x)
The strategy configuration was canceled because "build.ubuntu_20_x" failed
build (ubuntu, 18.x)
The operation was canceled.
tests/rule-setup.js > rules setup is correct > should mention all rules in the README: tests/rule-setup.js#L81
AssertionError: expected '# eslint-plugin-ember\n\n[![NPM versi…' to contain 'template-no-invalid-aria-attributes' - Expected + Received - template-no-invalid-aria-attributes + # eslint-plugin-ember + + [![NPM version](https://img.shields.io/npm/v/eslint-plugin-ember.svg?style=flat)](https://npmjs.org/package/eslint-plugin-ember) + [![NPM downloads](https://img.shields.io/npm/dm/eslint-plugin-ember.svg?style=flat)](https://npmjs.org/package/eslint-plugin-ember) + ![CI](https://github.com/ember-cli/eslint-plugin-ember/workflows/CI/badge.svg) + + > An ESLint plugin that provides a set of rules for Ember applications based on commonly known good practices. + + ## ❗️Requirements + + - [ESLint](https://eslint.org/) `>= 8` + - [Node.js](https://nodejs.org/) `18.* || 20.* || >= 21` + + ## 🚀 Usage + + ### 1. Install plugin + + ```shell + npm install --save-dev eslint-plugin-ember + ``` + + ### 2. Update your config + + ```js + // eslint.config.js (flat config) + const eslintPluginEmberRecommended = require('eslint-plugin-ember/configs/recommended'); + + module.exports = [ + ...eslintPluginEmberRecommended, + ]; + ``` + + or + + ```js + // .eslintrc.js (legacy config) + module.exports = { + plugins: ['ember'], + extends: [ + 'eslint:recommended', + 'plugin:ember/recommended' // or other configuration + ], + rules: { + // override / enable optional rules + 'ember/no-replace-test-comments': 'error' + } + }; + ``` + + ## gts/gjs + + lint files having `First-Class Component Templates` (fcct) + + learn more [here](https://github.com/ember-template-imports/ember-template-imports) + + > [!NOTE] + > special care should be used when setting up parsers, since they cannot be overwritten. thus they should be used in override only and specific to file types + + gjs/gts support is provided by the [ember-eslint-parser](https://github.com/NullVoxPopuli/ember-eslint-parser) + + > [!NOTE] + > if you import .gts files in .ts files, then `ember-eslint-parser` is required for .ts as well to enable typed linting + + ```js + // .eslintrc.js + module.exports = { + overrides: [ + { + files: ['**/*.{js,ts}'], + plugins: ['ember'], + parser: '@typescript-eslint/parser', + extends: [ + 'eslint:recommended', + 'plugin:ember/recommended', // or other configuration + ], + rules: { + // override / enable optional rules + 'ember/no-replace-test-comments': 'error' + } + }, + { + files: ['**/*.gts'], + parser: 'ember-eslint-parser', + plugins: ['ember'], + extends: [ + 'eslint:recommended', + 'plugin:@typescript-eslint/recommended', + 'plugin:ember/recommended', + 'plugin:ember/recommended-gts', + ], + }, + { + files: ['**/*.gjs'], + parser: 'ember-eslint-parser', + plugins: ['ember'], + extends: [ + 'eslint:recommended', + 'plugin:ember/recommended', + 'plugin:ember/recommended-gjs', + ], + }, + { + files: ['tests/**/*.{js,ts,gjs,gts}'], + rules: { + // override / enable optional rules + 'ember/no-replace-test-comments': 'error' + } + }, + ], + }; + ``` + + ### rules applied to fcct templates + + - semi rule, same as [prettier plugin](https://github.com/gitKrystan/prettier-plugin-ember-template-tag/issues/1) + - no-undef rule will take effect for template vars (includes js scope) + - no-unused rule will take effect for template block params + + rules in templates can be disabled with eslint directives with mustache or html comments: + + ```hbs + <template> + <div> + {{!eslint-disable-next-line}} + {{test}} + </div> + <div> + {{!--eslint-disable--}} + {{test}} + {{test}} + {{test}} + {{!--eslint-enable--}} + </div> + </template> + ``` + + ```hbs + <template> + <div> + <!--eslint-disable-next-line--> + {{test}} + </div> + <div> + <!-- eslint-disable --> + {{test}} + {{test}} + {{test}} + <!-- eslint-ena