breaking: require Node.js version >= 20.19 (#1671)

* fix: By bumping node version to v20.19 we will fix the @handlebars/parser issue

- Reported in #1669

* fix: Do use lockfile!

- Without this the CI fails, because it installs incorrect dependencies

* fix: Node version requirement >= 20.19

- Fixes #1669

Caused by:

```
require() of ES Module .../.pnpm/@handlebars+parser@file+..+handlebars-parser/node_modules/@handlebars/parser/dist/cjs/index.js not supported.
Instead change the require of index.js in null to a dynamic import() which is available in all CommonJS modules.
```

When using older node in consuming app.

Author: MichalBryxi

.github/workflows/addon-docs.yml

@@ -23,7 +23,7 @@ jobs:
           # Fetch tags pointing to the current commit
           TAGS=$(git tag --points-at $GITHUB_SHA)
           echo "Tags found: $TAGS"
-          
+
           # Check if a tag exists and if the ref is 'refs/heads/main' or 'refs/heads/master'
           if [ -n "$TAGS" ] && ([[ "${GITHUB_REF}" == "refs/heads/main" ]] || [[ "${GITHUB_REF}" == "refs/heads/master" ]]); then
             echo "SHORT_CIRCUIT=true" >> $GITHUB_ENV
@@ -41,7 +41,7 @@ jobs:
           cache: pnpm
       - name: Install Dependencies
         if: env.SHORT_CIRCUIT == 'false'
-        run: pnpm install --no-lockfile
+        run: pnpm install
       - name: Deploy Docs
         if: env.SHORT_CIRCUIT == 'false'
-        run: pnpm ember deploy production
+        run: pnpm ember deploy production

.github/workflows/ci-cd.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.19.x
       - uses: pnpm/action-setup@v4
         with:
           version: 9
@@ -46,12 +46,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.19.x
       - uses: pnpm/action-setup@v4
         with:
           version: 9
       - name: Install dependencies
-        run: pnpm i --no-lockfile
+        run: pnpm i
       - name: Test
         run: pnpm test:${{ matrix.script-name }}
 
@@ -71,7 +71,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.19.x
       - uses: pnpm/action-setup@v4
         with:
           version: 9
@@ -103,7 +103,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.19.x
       - uses: pnpm/action-setup@v4
         with:
           version: 9

.tool-versions

@@ -1,2 +1,2 @@
-nodejs 18.20.3
-pnpm 9.9.0
+nodejs 20.19
+pnpm 9.9.0

package.json

@@ -36,7 +36,7 @@
     "@glimmer/component": "^1.1.2",
     "@glimmer/syntax": "^0.87.1",
     "@glimmer/tracking": "^1.1.2",
-    "@handlebars/parser": "^2.1.0",
+    "@handlebars/parser": "^2.2.0",
     "broccoli-bridge": "^1.0.0",
     "broccoli-caching-writer": "^3.0.3",
     "broccoli-filter": "^1.3.0",
@@ -190,7 +190,7 @@
     }
   },
   "engines": {
-    "node": ">= 18"
+    "node": ">= 20.19"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"

pnpm-lock.yaml

@@ -52,7 +52,7 @@
     "webpack": "^5.96.1"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 20.19"
   },
   "ember": {
     "edition": "octane"

test-apps/new-addon/package.json

@@ -136,7 +136,7 @@ jobs:
           cache: pnpm
       - name: Install Dependencies
         if: env.SHORT_CIRCUIT == 'false'
-        run: pnpm install --no-lockfile
+        run: pnpm install
       - name: Deploy Docs
         if: env.SHORT_CIRCUIT == 'false'
         run: pnpm ember deploy production

tests/dummy/app/templates/docs/deploying.md

@@ -7,6 +7,16 @@ To use AddonDocs, your addon must have a `devDependency` of **Ember v2.8** or hi
 Note that your addon can still support older versions of Ember – it's just that you won't be able to run your AddonDocs documentation site against those older versions. (This means you also cannot write acceptance/application tests against your docs sites on older versions of Ember.)
 
 
+### Node version
+
+Due to [this issue](https://github.com/ember-learn/ember-cli-addon-docs/issues/1669) there is a requirement for consuming app to use [node>=20.19](https://nodejs.org/en/blog/release/v20.19.0/). Otherwise you might get following error during build:
+
+```
+require() of ES Module .../.pnpm/@handlebars+parser@file+..+handlebars-parser/node_modules/@handlebars/parser/dist/cjs/index.js not supported.
+Instead change the require of index.js in null to a dynamic import() which is available in all CommonJS modules.
+```
+
+
 ## Installation
 
 ```sh