Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-default resolver can cause bugs #44

Open
pzuraq opened this issue Mar 28, 2020 · 0 comments
Open

Non-default resolver can cause bugs #44

pzuraq opened this issue Mar 28, 2020 · 0 comments

Comments

@pzuraq
Copy link
Collaborator

pzuraq commented Mar 28, 2020

If the default resolver is not included, the try/catch in the resolve patch will throw before patching Ember Data and never resolve correctly. We should replace the try/catch entirely with a checking the module registry directly to see if the packages exist, before patching them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant