Fresh Ember addon indirectly depends on core-js@2 #20818
Comments
|
All of this is from babel -- not much we can do? tho, do you have suggestions? |
|
By "babel" do you mean ember-cli-babel? Because that seems to be the culprit. It seems to me that I don't have any suggestions as I find the JS world quite confusing. How does this happen? How can it be fixed? |
|
well, just @babel/polyfill 7.12.1
└── core-js 2.6.12are you saying this isn't needed anymore? |
|
I don't know. Is it needed? According to the Babel website itself, I initialized a new Ember 5.12 addon to cross-check what a modern addon would depend on and it seems to depend on ancient packages. What I did: Then when checking for Where did I go wrong? |
|
we need ember-cli-babel, the main issue is whether or not we can get rid of A subset of your initial query would be helpful pnpm why @babel/polyfilllooks like you'd get
not sure of any others. Which, I'm a huge fan of, as less dependencies is better for everyone! |
|
Querying for Is this helpful instead? Honestly I don't know much about JS stuff. I just know that core-js@2 is not maintained anymore and I was surprised that a modern Ember addon would depend on it. |
|
not particularly, the output from --parseable doesn't give us the hierarchy
this is fair -- however the build system also supports libraries from the dark ages -- compatibility or rather "stability without stagnation" is ember's motto |
|
ember-cli-babel v8 got rid of @babel/polyfill, so we just need to make sure that ember-cli-babel v7 isn't used anymore. |
|
How do I use |
|
You can force v8 using E.g. Yarn resolutions or pnpm overrides, but we should also try to update to v8 in those packages as well. |
|
I've tried using pnpm overrides in our app and two addons like this: + "pnpm": {
+ "overrides": {
+ "ember-cli-babel": "^8.2.0"
+ }
+ },This seems to work. No more Can this issue be used to coordinate the upgrade to ember-cli-babel v8 in other Ember projects? |
|
I guess it can. |
🐞 Describe the Bug
I've noticed that even a freshly initialized Ember 5.12.0 addon depends on [email protected], which is deprecated. This seems to happen because:
🔬 Minimal Reproduction
😕 Actual Behavior
Deprecated packages are in the dependencies.
🤔 Expected Behavior
I expect non-deprecated packages are in the dependencies.
🌍 Environment
The text was updated successfully, but these errors were encountered: