Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Refactor to ES6 #44

Open
lukasaric opened this issue May 16, 2019 · 5 comments
Open

[Suggestion] Refactor to ES6 #44

lukasaric opened this issue May 16, 2019 · 5 comments

Comments

@lukasaric
Copy link

lukasaric commented May 16, 2019 •
edited
Loading

Refactor this packet to JavaScript ES6?
@emerleite
Copy link
Owner

For sure. Can u send a PR? Thanks !!!

@danielsogl
Copy link

@emerleite I could create a PR including TypeScript support and es5/es6 bundles.What do you think about that?

@lukasaric
Copy link
Author

lukasaric commented Jun 12, 2019 •
edited
Loading

For sure. Can u send a PR? Thanks !!!

Need permission to push origin PR. Please, give me access and I will send a PR :bowtie: .

@danielsogl
Copy link

@lukasaric you don't need access to create a PR. You have to fork the repo and create a new branch from master.

@zcuric zcuric mentioned this issue Jun 14, 2019
Open
@vladimyr
Copy link

@emerleite I could create a PR including TypeScript support and es5/es6 bundles.What do you think about that?

Done. But I'm pretty much typescript n00b so please take a look on what I did here: #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@emerleite @vladimyr @danielsogl @lukasaric