From c092826624a421f768394097780e19be6bd67229 Mon Sep 17 00:00:00 2001
From: Manfred Bergmann <mb@software-by-mabe.com>
Date: Sun, 23 Jan 2022 18:59:55 +0100
Subject: [PATCH] Doing the Erlang way, extracted item into separate file as
 include.

---
 lfe/include/gilded-rose-item.lfe |  4 ++++
 lfe/src/gilded-rose.lfe          | 11 +----------
 lfe/test/gilded-rose-test.lfe    |  8 ++++----
 3 files changed, 9 insertions(+), 14 deletions(-)
 create mode 100644 lfe/include/gilded-rose-item.lfe

diff --git a/lfe/include/gilded-rose-item.lfe b/lfe/include/gilded-rose-item.lfe
new file mode 100644
index 0000000000..f9ab5191e8
--- /dev/null
+++ b/lfe/include/gilded-rose-item.lfe
@@ -0,0 +1,4 @@
+;;; Item
+
+(defrecord item
+  name sellin quality)
diff --git a/lfe/src/gilded-rose.lfe b/lfe/src/gilded-rose.lfe
index 772abfbbe9..a135ecc7dd 100644
--- a/lfe/src/gilded-rose.lfe
+++ b/lfe/src/gilded-rose.lfe
@@ -46,16 +46,7 @@
 (defmodule gilded-rose
   (export all))
 
-;;; Item
-
-(defrecord item
-  name sellin quality)
-
-;; for external use by 'import'
-(defun make-item (name sellin quality)
-  (make-item name name sellin sellin quality quality))
-(defun item-name (item)
-  (item-name item))
+(include-lib "include/gilded-rose-item.lfe")
 
 ;; update-quality
 
diff --git a/lfe/test/gilded-rose-test.lfe b/lfe/test/gilded-rose-test.lfe
index 5657effe47..090758257e 100644
--- a/lfe/test/gilded-rose-test.lfe
+++ b/lfe/test/gilded-rose-test.lfe
@@ -2,12 +2,12 @@
   (behaviour ltest-unit)
   (export all)
   (import (from gilded-rose
-                (update-quality 1)
-                (make-item 3)
-                (item-name 1))))
+                (update-quality 1))))
 
 (include-lib "ltest/include/ltest-macros.lfe")
 
+(include-lib "include/gilded-rose-item.lfe")
+
 (deftest update-quality-test
   (is-equal "foo" (item-name (car (update-quality
-                                   (list (make-item "foo" 0 0)))))))
+                                   (list (make-item name "foo" sellin 0 quality 0)))))))