Igir hangs when handling zip files that have an "archive comment"

[conchyliculture]

Paste the command

./igir -v copy zip test --dat /tmp/dats/No-Intro/* --input /tmp/roms/ --output /tmp/roms2 --dir-dat-name

Describe the bug

Scanning for DATs passes, but while the tool is scanning roms, it will hang on the zip files that have a "archive comment", aslo called "File comment", that can be added to the end of the zip central directory when creating a zip (for example with --archive-comment if uzing zip from Info-zip

Unzipping these archives, and re-zipping then without the comment fixes the issue

Expected behavior

No hanging

Debug logs

DAT(s) used

No response

igir version

v.3.0.1

Node.js version

N/A

Operating system

debian testing

Additional context

This is also what might be causing #1399

[emmercm]

@conchyliculture could you provide an example unzip -v <file> of a problematic archive?

I tried making a fresh archive using Info-ZIP, as mentioned, with the latest version being v3.0 from July 5th, 2008:

zip -9 -v -z fourfive.zip four.rom five.rom

and the resulting file extracts just fine:

$ unzip -v fourfive.zip
Archive:  fourfive.zip
Comment line one
Comment line two
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
       5  Stored        5   0% 05-12-2023 13:19 1cf3ca74  four.rom
       5  Stored        5   0% 05-12-2023 13:19 3e5daf67  five.rom
--------          -------  ---                            -------
      10               10   0%                            2 files

[emmercm]

I suspect you're right that your situation is related to #1399, but this issue is described as something else, so I want to make sure there isn't a separate issue.

[github-actions]

⏳ Stale issue warning

This issue is stale because it has been open 14 days with no activity. Comment or this will be automatically closed in 14 days.

Comment generated by the GitHub Stale Issues workflow.