Skip to content

Commit 87d9a75

Browse files
authored
[CI] Update versions of node under test (#25653)
- Update the newest versions node to 24.10.0 - Add addition testing of current LTS version (22.21.0)
1 parent f2a7cc7 commit 87d9a75

File tree

1 file changed

+38
-10
lines changed

1 file changed

+38
-10
lines changed

.circleci/config.yml

Lines changed: 38 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,22 @@ commands:
106106
echo "if os.path.exists(V8_ENGINE[0]): JS_ENGINES.append(V8_ENGINE)" >> ~/emsdk/.emscripten
107107
cat ~/emsdk/.emscripten
108108
echo "export PATH=\"$HOME/node-v${version}-linux-x64/bin:\$PATH\"" >> $BASH_ENV
109-
install-node-latest:
110-
description: "install latest version of node"
109+
install-node-oldest:
110+
description: "install node (oldest)"
111111
steps:
112112
- install-node-version:
113-
node_version: "19.0.0"
113+
# Keep this in sync with `OLDEST_SUPPORTED_NODE` in `feature_matrix.py`
114+
node_version: "12.22.9"
115+
install-node-lts:
116+
description: "install node (current LTS)"
117+
steps:
118+
- install-node-version:
119+
node_version: "22.21.0"
120+
install-node-newest:
121+
description: "install node (newest)"
122+
steps:
123+
- install-node-version:
124+
node_version: "24.10.0"
114125
install-node-canary:
115126
description: "install canary version of node"
116127
steps:
@@ -957,9 +968,7 @@ jobs:
957968
"
958969
# Run some basic tests with the minimum version of node that we currently
959970
# support in the generated code.
960-
# Keep this in sync with `OLDEST_SUPPORTED_NODE` in `feature_matrix.py`
961-
- install-node-version:
962-
node_version: "12.22.9"
971+
- install-node-oldest
963972
- run-tests:
964973
title: "node (oldest / 12.22.9)"
965974
extra-cflags: "-sMIN_NODE_VERSION=122209"
@@ -1023,10 +1032,28 @@ jobs:
10231032
core2.test_unistd_unlink_rawfs
10241033
core2.test_unistd_write_broken_link_rawfs
10251034
"
1035+
# Run a few test with the most recent LTS version of node
1036+
- install-node-lts
1037+
- run-tests:
1038+
# Run tests that on older versions of node would require flags, but
1039+
# those flags should not be injected on newer versions.
1040+
title: "node (lts)"
1041+
test_targets: "-v
1042+
other.test_gen_struct_info
1043+
other.test_native_call_before_init
1044+
other.test_node_unhandled_rejection
1045+
other.test_js_optimizer_verbose
1046+
other.test_min_node_version
1047+
other.test_node_emscripten_num_logical_cores
1048+
core2.test_pthread_create
1049+
core2.test_i64_invoke_bigint
1050+
core2.test_sse2
1051+
core2.test_source_map
1052+
core2.test_exceptions_wasm_legacy
1053+
core2.test_pthread_unhandledrejection
1054+
"
10261055
# Run a few test with the most recent version of node
1027-
# In particular we have some tests that require node flags on older
1028-
# versions of node but not with the most recent version.
1029-
- install-node-latest
1056+
- install-node-newest
10301057
- run-tests:
10311058
# Run tests that on older versions of node would require flags, but
10321059
# those flags should not be injected on newer versions.
@@ -1043,7 +1070,8 @@ jobs:
10431070
core2.test_sse2
10441071
core2.test_source_map
10451072
core2.test_exceptions_wasm_legacy
1046-
core2.test_pthread_unhandledrejection"
1073+
core2.test_pthread_unhandledrejection
1074+
"
10471075
- upload-test-results
10481076
test-other:
10491077
executor: focal

0 commit comments

Comments
 (0)