Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should JSPI be tested without --experimental-wasm-type-reflection? #23600

Open
hoodmane opened this issue Feb 5, 2025 · 3 comments
Open

Should JSPI be tested without --experimental-wasm-type-reflection? #23600

hoodmane opened this issue Feb 5, 2025 · 3 comments

Comments

@hoodmane
Copy link
Collaborator

hoodmane commented Feb 5, 2025

Currently require_jspi() adds --experimental-wasm-stack-switching --experimental-wasm-type-reflection. But (I hope that) JSPI is going to stage 4 pretty soon and type reflection seems like it'll stay in stage 3 a while longer. So if JSPI support relies on type reflection, it may delay people being able to use it.

@sbc100
Copy link
Collaborator

sbc100 commented Feb 5, 2025

Good point, I think its was previously needed but no longer. I think it can be removed. @brendandahl can confirm. Would you like to send a PR?

@hoodmane
Copy link
Collaborator Author

hoodmane commented Feb 5, 2025

Yeah I can send a pr. Though I mention this because wasm type reflection makes fixing #23395 more complicated. So I was thinking about first doing a fix that requires type reflection and then removing the dependency on type reflection.

@brendandahl
Copy link
Collaborator

JSPI should no longer require type reflection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants