From 9c9893d79c95a9ea6fef2b9dd4ba4d61c89af749 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Fri, 10 Jan 2025 11:10:12 +0100 Subject: [PATCH 1/8] Make fstat work on file descriptors with no name in node rawfs This fixes fstat on "anonymous" file descriptors in node rawfs. It is split off from #23058. --- src/library_fs.js | 3 +++ src/library_noderawfs.js | 4 ++++ src/library_syscall.js | 3 +-- test/fs/test_stat_unnamed_file_descriptor.c | 20 ++++++++++++++++++++ test/test_core.py | 10 ++++++++++ 5 files changed, 38 insertions(+), 2 deletions(-) create mode 100644 test/fs/test_stat_unnamed_file_descriptor.c diff --git a/src/library_fs.js b/src/library_fs.js index 7ba5ebec5aa9f..1abafb227eecc 100644 --- a/src/library_fs.js +++ b/src/library_fs.js @@ -956,6 +956,9 @@ FS.staticInit(); } return node.node_ops.getattr(node); }, + fstat(fd) { + return FS.stat(FS.getStreamChecked(fd).node); + }, lstat(path) { return FS.stat(path, true); }, diff --git a/src/library_noderawfs.js b/src/library_noderawfs.js index 81ab16962a89c..a6d38afdce744 100644 --- a/src/library_noderawfs.js +++ b/src/library_noderawfs.js @@ -79,6 +79,10 @@ addToLibrary({ } return stat; }, + fstat(fd) { + var stream = FS.getStreamChecked(fd); + return fs.fstatSync(stream.nfd); + }, chmod(path, mode, dontFollow) { mode &= {{{ cDefs.S_IALLUGO }}}; if (NODEFS.isWindows) { diff --git a/src/library_syscall.js b/src/library_syscall.js index 6acb166b457b8..94ccc495d4fcb 100644 --- a/src/library_syscall.js +++ b/src/library_syscall.js @@ -678,8 +678,7 @@ var SyscallsLibrary = { return SYSCALLS.writeStat(buf, FS.lstat(path)); }, __syscall_fstat64: (fd, buf) => { - var stream = SYSCALLS.getStreamFromFD(fd); - return SYSCALLS.writeStat(buf, FS.stat(stream.path)); + return SYSCALLS.writeStat(buf, FS.fstat(fd)); }, __syscall_fchown32: (fd, owner, group) => { FS.fchown(fd, owner, group); diff --git a/test/fs/test_stat_unnamed_file_descriptor.c b/test/fs/test_stat_unnamed_file_descriptor.c new file mode 100644 index 0000000000000..a1d92f5cbaba7 --- /dev/null +++ b/test/fs/test_stat_unnamed_file_descriptor.c @@ -0,0 +1,20 @@ +#include +#include +#include +#include +#include "stdio.h" + +int main() { + int fd = open("file.txt", O_RDWR | O_CREAT, 0666); + unlink("file.txt"); + int res; + struct stat buf; + res = fstat(fd, &buf); + assert(res == 0); + assert(buf.st_atime > 1000000000); + res = fchmod(fd, 0777); + assert(res == 0); + res = ftruncate(fd, 10); + assert(res == 0); + printf("success\n"); +} diff --git a/test/test_core.py b/test/test_core.py index f22252f32ce66..b770fe4607f0e 100644 --- a/test/test_core.py +++ b/test/test_core.py @@ -5847,6 +5847,16 @@ def test_fs_64bit(self): self.set_setting('FORCE_FILESYSTEM') self.do_runf('fs/test_64bit.c', 'success') + @crossplatform + @also_with_noderawfs + def test_fs_stat_unnamed_file_descriptor(self): + nodefs = '-DNODEFS' in self.emcc_args or '-DNODERAWFS' in self.emcc_args + if self.get_setting('WASMFS'): + if nodefs: + self.skipTest('NODEFS in WasmFS') + self.set_setting('FORCE_FILESYSTEM') + self.do_runf('fs/test_stat_unnamed_file_descriptor.c', 'success') + @requires_node @crossplatform @with_all_fs From 165ac3bd9d18dac719039d0926bcf44b49bdf324 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Fri, 10 Jan 2025 11:19:46 +0100 Subject: [PATCH 2/8] Clean up test --- test/test_core.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/test_core.py b/test/test_core.py index b770fe4607f0e..702339bcd7104 100644 --- a/test/test_core.py +++ b/test/test_core.py @@ -5850,11 +5850,6 @@ def test_fs_64bit(self): @crossplatform @also_with_noderawfs def test_fs_stat_unnamed_file_descriptor(self): - nodefs = '-DNODEFS' in self.emcc_args or '-DNODERAWFS' in self.emcc_args - if self.get_setting('WASMFS'): - if nodefs: - self.skipTest('NODEFS in WasmFS') - self.set_setting('FORCE_FILESYSTEM') self.do_runf('fs/test_stat_unnamed_file_descriptor.c', 'success') @requires_node From 71878574fae6bc4dbc29cdb6752c2d9b415570f5 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Fri, 10 Jan 2025 15:55:34 +0100 Subject: [PATCH 3/8] fix --- src/library_fs.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/library_fs.js b/src/library_fs.js index 1abafb227eecc..b35cf501215c4 100644 --- a/src/library_fs.js +++ b/src/library_fs.js @@ -957,7 +957,7 @@ FS.staticInit(); return node.node_ops.getattr(node); }, fstat(fd) { - return FS.stat(FS.getStreamChecked(fd).node); + return FS.stat(FS.getStreamChecked(fd).path); }, lstat(path) { return FS.stat(path, true); From eeee049b058e905c44dc8567eaf993c2370e9d51 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Fri, 10 Jan 2025 16:49:55 +0100 Subject: [PATCH 4/8] Skip test except in noderawfs --- test/test_core.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/test_core.py b/test/test_core.py index 702339bcd7104..e6eeac4f415f2 100644 --- a/test/test_core.py +++ b/test/test_core.py @@ -5848,8 +5848,11 @@ def test_fs_64bit(self): self.do_runf('fs/test_64bit.c', 'success') @crossplatform - @also_with_noderawfs + @also_with_nodefs_both def test_fs_stat_unnamed_file_descriptor(self): + noderawfs = '-DNODERAWFS' in self.emcc_args + if not noderawfs: + self.skipTest('TODO: only works in noderawfs for now') self.do_runf('fs/test_stat_unnamed_file_descriptor.c', 'success') @requires_node From 771e484271baf68dc98619568498c08907a1a636 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Wed, 15 Jan 2025 21:31:20 +0100 Subject: [PATCH 5/8] Automatic rebaseline of codesize expectations. NFC This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (13) test expectation files were updated by running the tests with `--rebaseline`: ``` other/codesize/test_codesize_cxx_ctors1.size: 129211 => 129218 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_ctors2.size: 128623 => 128630 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_except.size: 170879 => 170886 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_except_wasm.size: 142162 => 142169 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_except_wasm_exnref.size: 144708 => 144715 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_mangle.size: 232724 => 232731 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_noexcept.size: 131774 => 131781 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_wasmfs.size: 169181 => 169188 [+7 bytes / +0.00%] other/codesize/test_codesize_hello_O0.size: 15101 => 15113 [+12 bytes / +0.08%] other/codesize/test_codesize_minimal_pthreads.size: 19394 => 19405 [+11 bytes / +0.06%] other/test_unoptimized_code_size.wasm.size: 15101 => 15113 [+12 bytes / +0.08%] other/test_unoptimized_code_size_no_asserts.wasm.size: 12182 => 12194 [+12 bytes / +0.10%] other/test_unoptimized_code_size_strict.wasm.size: 15101 => 15113 [+12 bytes / +0.08%] Average change: +0.03% (+0.00% - +0.10%) ``` --- test/other/codesize/test_codesize_cxx_ctors1.size | 2 +- test/other/codesize/test_codesize_cxx_ctors2.size | 2 +- test/other/codesize/test_codesize_cxx_except.size | 2 +- test/other/codesize/test_codesize_cxx_except_wasm.size | 2 +- test/other/codesize/test_codesize_cxx_except_wasm_exnref.size | 2 +- test/other/codesize/test_codesize_cxx_mangle.size | 2 +- test/other/codesize/test_codesize_cxx_noexcept.size | 2 +- test/other/codesize/test_codesize_cxx_wasmfs.size | 2 +- test/other/codesize/test_codesize_hello_O0.size | 2 +- test/other/codesize/test_codesize_minimal_pthreads.size | 2 +- test/other/test_unoptimized_code_size.wasm.size | 2 +- test/other/test_unoptimized_code_size_no_asserts.wasm.size | 2 +- test/other/test_unoptimized_code_size_strict.wasm.size | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/test/other/codesize/test_codesize_cxx_ctors1.size b/test/other/codesize/test_codesize_cxx_ctors1.size index 59ec2c640a663..a3b5de60e54aa 100644 --- a/test/other/codesize/test_codesize_cxx_ctors1.size +++ b/test/other/codesize/test_codesize_cxx_ctors1.size @@ -1 +1 @@ -129211 +129218 diff --git a/test/other/codesize/test_codesize_cxx_ctors2.size b/test/other/codesize/test_codesize_cxx_ctors2.size index 37ec3b55a7a82..0ee50d8f96ee0 100644 --- a/test/other/codesize/test_codesize_cxx_ctors2.size +++ b/test/other/codesize/test_codesize_cxx_ctors2.size @@ -1 +1 @@ -128623 +128630 diff --git a/test/other/codesize/test_codesize_cxx_except.size b/test/other/codesize/test_codesize_cxx_except.size index 5dab383a3c420..1bae0e2d633b9 100644 --- a/test/other/codesize/test_codesize_cxx_except.size +++ b/test/other/codesize/test_codesize_cxx_except.size @@ -1 +1 @@ -170879 +170886 diff --git a/test/other/codesize/test_codesize_cxx_except_wasm.size b/test/other/codesize/test_codesize_cxx_except_wasm.size index 28cf96ad77953..cdbcd17b502d1 100644 --- a/test/other/codesize/test_codesize_cxx_except_wasm.size +++ b/test/other/codesize/test_codesize_cxx_except_wasm.size @@ -1 +1 @@ -142162 +142169 diff --git a/test/other/codesize/test_codesize_cxx_except_wasm_exnref.size b/test/other/codesize/test_codesize_cxx_except_wasm_exnref.size index c7d57a3be3df7..b122612579300 100644 --- a/test/other/codesize/test_codesize_cxx_except_wasm_exnref.size +++ b/test/other/codesize/test_codesize_cxx_except_wasm_exnref.size @@ -1 +1 @@ -144708 +144715 diff --git a/test/other/codesize/test_codesize_cxx_mangle.size b/test/other/codesize/test_codesize_cxx_mangle.size index 004d7d333c79a..8e8b38b5c13b0 100644 --- a/test/other/codesize/test_codesize_cxx_mangle.size +++ b/test/other/codesize/test_codesize_cxx_mangle.size @@ -1 +1 @@ -232724 +232731 diff --git a/test/other/codesize/test_codesize_cxx_noexcept.size b/test/other/codesize/test_codesize_cxx_noexcept.size index c0e3f17ce269c..232be2fc5f578 100644 --- a/test/other/codesize/test_codesize_cxx_noexcept.size +++ b/test/other/codesize/test_codesize_cxx_noexcept.size @@ -1 +1 @@ -131774 +131781 diff --git a/test/other/codesize/test_codesize_cxx_wasmfs.size b/test/other/codesize/test_codesize_cxx_wasmfs.size index 3b73c05a4a345..b592a30c75210 100644 --- a/test/other/codesize/test_codesize_cxx_wasmfs.size +++ b/test/other/codesize/test_codesize_cxx_wasmfs.size @@ -1 +1 @@ -169181 +169188 diff --git a/test/other/codesize/test_codesize_hello_O0.size b/test/other/codesize/test_codesize_hello_O0.size index aa9255e00128e..96b0a1d19abf4 100644 --- a/test/other/codesize/test_codesize_hello_O0.size +++ b/test/other/codesize/test_codesize_hello_O0.size @@ -1 +1 @@ -15101 +15113 diff --git a/test/other/codesize/test_codesize_minimal_pthreads.size b/test/other/codesize/test_codesize_minimal_pthreads.size index 5f7ea76a0569f..0f60aa5d0b843 100644 --- a/test/other/codesize/test_codesize_minimal_pthreads.size +++ b/test/other/codesize/test_codesize_minimal_pthreads.size @@ -1 +1 @@ -19394 +19405 diff --git a/test/other/test_unoptimized_code_size.wasm.size b/test/other/test_unoptimized_code_size.wasm.size index aa9255e00128e..96b0a1d19abf4 100644 --- a/test/other/test_unoptimized_code_size.wasm.size +++ b/test/other/test_unoptimized_code_size.wasm.size @@ -1 +1 @@ -15101 +15113 diff --git a/test/other/test_unoptimized_code_size_no_asserts.wasm.size b/test/other/test_unoptimized_code_size_no_asserts.wasm.size index e15b709b7d237..59029a8227a5f 100644 --- a/test/other/test_unoptimized_code_size_no_asserts.wasm.size +++ b/test/other/test_unoptimized_code_size_no_asserts.wasm.size @@ -1 +1 @@ -12182 +12194 diff --git a/test/other/test_unoptimized_code_size_strict.wasm.size b/test/other/test_unoptimized_code_size_strict.wasm.size index aa9255e00128e..96b0a1d19abf4 100644 --- a/test/other/test_unoptimized_code_size_strict.wasm.size +++ b/test/other/test_unoptimized_code_size_strict.wasm.size @@ -1 +1 @@ -15101 +15113 From e6fab21191283c5f4fc2681e5e7345a0c16a3959 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Wed, 22 Jan 2025 13:20:07 +0100 Subject: [PATCH 6/8] Run test in wasmfs too --- test/test_core.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/test_core.py b/test/test_core.py index 22b371a0f62ca..f076a0daf65b9 100644 --- a/test/test_core.py +++ b/test/test_core.py @@ -5848,11 +5848,12 @@ def test_fs_64bit(self): self.do_runf('fs/test_64bit.c', 'success') @crossplatform - @also_with_nodefs_both + @with_all_fs def test_fs_stat_unnamed_file_descriptor(self): noderawfs = '-DNODERAWFS' in self.emcc_args - if not noderawfs: - self.skipTest('TODO: only works in noderawfs for now') + wasmfs = self.get_setting('WASMFS') + if not (noderawfs or wasmfs): + self.skipTest('TODO: doesnt work in memfs or nodefs') self.do_runf('fs/test_stat_unnamed_file_descriptor.c', 'success') @requires_node From 4ade6eae2a0dd7d2abe06ec9c4792db120d4a355 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Wed, 22 Jan 2025 13:20:43 +0100 Subject: [PATCH 7/8] Revert codesize changes --- test/other/codesize/test_codesize_cxx_ctors1.size | 2 +- test/other/codesize/test_codesize_cxx_ctors2.size | 2 +- test/other/codesize/test_codesize_cxx_except.size | 2 +- test/other/codesize/test_codesize_cxx_except_wasm.size | 2 +- .../test_codesize_cxx_except_wasm_legacy.exports | 6 ++++++ .../codesize/test_codesize_cxx_except_wasm_legacy.gzsize | 1 + .../test_codesize_cxx_except_wasm_legacy.imports | 9 +++++++++ .../codesize/test_codesize_cxx_except_wasm_legacy.jssize | 1 + .../codesize/test_codesize_cxx_except_wasm_legacy.sent | 9 +++++++++ .../codesize/test_codesize_cxx_except_wasm_legacy.size | 1 + test/other/codesize/test_codesize_cxx_mangle.size | 2 +- test/other/codesize/test_codesize_cxx_noexcept.size | 2 +- test/other/codesize/test_codesize_cxx_wasmfs.size | 2 +- test/other/codesize/test_codesize_hello_O0.size | 2 +- test/other/codesize/test_codesize_minimal_pthreads.size | 2 +- 15 files changed, 36 insertions(+), 9 deletions(-) create mode 100644 test/other/codesize/test_codesize_cxx_except_wasm_legacy.exports create mode 100644 test/other/codesize/test_codesize_cxx_except_wasm_legacy.gzsize create mode 100644 test/other/codesize/test_codesize_cxx_except_wasm_legacy.imports create mode 100644 test/other/codesize/test_codesize_cxx_except_wasm_legacy.jssize create mode 100644 test/other/codesize/test_codesize_cxx_except_wasm_legacy.sent create mode 100644 test/other/codesize/test_codesize_cxx_except_wasm_legacy.size diff --git a/test/other/codesize/test_codesize_cxx_ctors1.size b/test/other/codesize/test_codesize_cxx_ctors1.size index a3b5de60e54aa..59ec2c640a663 100644 --- a/test/other/codesize/test_codesize_cxx_ctors1.size +++ b/test/other/codesize/test_codesize_cxx_ctors1.size @@ -1 +1 @@ -129218 +129211 diff --git a/test/other/codesize/test_codesize_cxx_ctors2.size b/test/other/codesize/test_codesize_cxx_ctors2.size index 0ee50d8f96ee0..37ec3b55a7a82 100644 --- a/test/other/codesize/test_codesize_cxx_ctors2.size +++ b/test/other/codesize/test_codesize_cxx_ctors2.size @@ -1 +1 @@ -128630 +128623 diff --git a/test/other/codesize/test_codesize_cxx_except.size b/test/other/codesize/test_codesize_cxx_except.size index 1bae0e2d633b9..5dab383a3c420 100644 --- a/test/other/codesize/test_codesize_cxx_except.size +++ b/test/other/codesize/test_codesize_cxx_except.size @@ -1 +1 @@ -170886 +170879 diff --git a/test/other/codesize/test_codesize_cxx_except_wasm.size b/test/other/codesize/test_codesize_cxx_except_wasm.size index cdbcd17b502d1..c7d57a3be3df7 100644 --- a/test/other/codesize/test_codesize_cxx_except_wasm.size +++ b/test/other/codesize/test_codesize_cxx_except_wasm.size @@ -1 +1 @@ -142169 +144708 diff --git a/test/other/codesize/test_codesize_cxx_except_wasm_legacy.exports b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.exports new file mode 100644 index 0000000000000..85bf5bc4006e4 --- /dev/null +++ b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.exports @@ -0,0 +1,6 @@ +__indirect_function_table +__trap +__wasm_call_ctors +_emscripten_stack_alloc +main +memory diff --git a/test/other/codesize/test_codesize_cxx_except_wasm_legacy.gzsize b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.gzsize new file mode 100644 index 0000000000000..116ecc04e8d72 --- /dev/null +++ b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.gzsize @@ -0,0 +1 @@ +8294 diff --git a/test/other/codesize/test_codesize_cxx_except_wasm_legacy.imports b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.imports new file mode 100644 index 0000000000000..686c058477034 --- /dev/null +++ b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.imports @@ -0,0 +1,9 @@ +env._abort_js +env._tzset_js +env.emscripten_resize_heap +wasi_snapshot_preview1.environ_get +wasi_snapshot_preview1.environ_sizes_get +wasi_snapshot_preview1.fd_close +wasi_snapshot_preview1.fd_read +wasi_snapshot_preview1.fd_seek +wasi_snapshot_preview1.fd_write diff --git a/test/other/codesize/test_codesize_cxx_except_wasm_legacy.jssize b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.jssize new file mode 100644 index 0000000000000..e2819c5beac21 --- /dev/null +++ b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.jssize @@ -0,0 +1 @@ +20166 diff --git a/test/other/codesize/test_codesize_cxx_except_wasm_legacy.sent b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.sent new file mode 100644 index 0000000000000..f307b35a2ffb0 --- /dev/null +++ b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.sent @@ -0,0 +1,9 @@ +_abort_js +_tzset_js +emscripten_resize_heap +environ_get +environ_sizes_get +fd_close +fd_read +fd_seek +fd_write diff --git a/test/other/codesize/test_codesize_cxx_except_wasm_legacy.size b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.size new file mode 100644 index 0000000000000..28cf96ad77953 --- /dev/null +++ b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.size @@ -0,0 +1 @@ +142162 diff --git a/test/other/codesize/test_codesize_cxx_mangle.size b/test/other/codesize/test_codesize_cxx_mangle.size index 8e8b38b5c13b0..004d7d333c79a 100644 --- a/test/other/codesize/test_codesize_cxx_mangle.size +++ b/test/other/codesize/test_codesize_cxx_mangle.size @@ -1 +1 @@ -232731 +232724 diff --git a/test/other/codesize/test_codesize_cxx_noexcept.size b/test/other/codesize/test_codesize_cxx_noexcept.size index 232be2fc5f578..c0e3f17ce269c 100644 --- a/test/other/codesize/test_codesize_cxx_noexcept.size +++ b/test/other/codesize/test_codesize_cxx_noexcept.size @@ -1 +1 @@ -131781 +131774 diff --git a/test/other/codesize/test_codesize_cxx_wasmfs.size b/test/other/codesize/test_codesize_cxx_wasmfs.size index b592a30c75210..3b73c05a4a345 100644 --- a/test/other/codesize/test_codesize_cxx_wasmfs.size +++ b/test/other/codesize/test_codesize_cxx_wasmfs.size @@ -1 +1 @@ -169188 +169181 diff --git a/test/other/codesize/test_codesize_hello_O0.size b/test/other/codesize/test_codesize_hello_O0.size index 96b0a1d19abf4..aa9255e00128e 100644 --- a/test/other/codesize/test_codesize_hello_O0.size +++ b/test/other/codesize/test_codesize_hello_O0.size @@ -1 +1 @@ -15113 +15101 diff --git a/test/other/codesize/test_codesize_minimal_pthreads.size b/test/other/codesize/test_codesize_minimal_pthreads.size index 0f60aa5d0b843..5f7ea76a0569f 100644 --- a/test/other/codesize/test_codesize_minimal_pthreads.size +++ b/test/other/codesize/test_codesize_minimal_pthreads.size @@ -1 +1 @@ -19405 +19394 From 1b50c902bf05bc8d5dc43214aec19c79b5b442b2 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Wed, 22 Jan 2025 13:22:48 +0100 Subject: [PATCH 8/8] Automatic rebaseline of codesize expectations. NFC This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (10) test expectation files were updated by running the tests with `--rebaseline`: ``` other/codesize/test_codesize_cxx_ctors1.size: 129211 => 129218 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_ctors2.size: 128623 => 128630 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_except.size: 170879 => 170886 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_except_wasm.size: 144708 => 144715 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_except_wasm_legacy.size: 142162 => 142169 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_mangle.size: 232724 => 232731 [+7 bytes / +0.00%] other/codesize/test_codesize_cxx_noexcept.size: 131774 => 131781 [+7 bytes / +0.01%] other/codesize/test_codesize_cxx_wasmfs.size: 169181 => 169188 [+7 bytes / +0.00%] other/codesize/test_codesize_hello_O0.size: 15101 => 15113 [+12 bytes / +0.08%] other/codesize/test_codesize_minimal_pthreads.size: 19394 => 19405 [+11 bytes / +0.06%] Average change: +0.02% (+0.00% - +0.08%) ``` --- test/other/codesize/test_codesize_cxx_ctors1.size | 2 +- test/other/codesize/test_codesize_cxx_ctors2.size | 2 +- test/other/codesize/test_codesize_cxx_except.size | 2 +- test/other/codesize/test_codesize_cxx_except_wasm.size | 2 +- test/other/codesize/test_codesize_cxx_except_wasm_legacy.size | 2 +- test/other/codesize/test_codesize_cxx_mangle.size | 2 +- test/other/codesize/test_codesize_cxx_noexcept.size | 2 +- test/other/codesize/test_codesize_cxx_wasmfs.size | 2 +- test/other/codesize/test_codesize_hello_O0.size | 2 +- test/other/codesize/test_codesize_minimal_pthreads.size | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/test/other/codesize/test_codesize_cxx_ctors1.size b/test/other/codesize/test_codesize_cxx_ctors1.size index 59ec2c640a663..a3b5de60e54aa 100644 --- a/test/other/codesize/test_codesize_cxx_ctors1.size +++ b/test/other/codesize/test_codesize_cxx_ctors1.size @@ -1 +1 @@ -129211 +129218 diff --git a/test/other/codesize/test_codesize_cxx_ctors2.size b/test/other/codesize/test_codesize_cxx_ctors2.size index 37ec3b55a7a82..0ee50d8f96ee0 100644 --- a/test/other/codesize/test_codesize_cxx_ctors2.size +++ b/test/other/codesize/test_codesize_cxx_ctors2.size @@ -1 +1 @@ -128623 +128630 diff --git a/test/other/codesize/test_codesize_cxx_except.size b/test/other/codesize/test_codesize_cxx_except.size index 5dab383a3c420..1bae0e2d633b9 100644 --- a/test/other/codesize/test_codesize_cxx_except.size +++ b/test/other/codesize/test_codesize_cxx_except.size @@ -1 +1 @@ -170879 +170886 diff --git a/test/other/codesize/test_codesize_cxx_except_wasm.size b/test/other/codesize/test_codesize_cxx_except_wasm.size index c7d57a3be3df7..b122612579300 100644 --- a/test/other/codesize/test_codesize_cxx_except_wasm.size +++ b/test/other/codesize/test_codesize_cxx_except_wasm.size @@ -1 +1 @@ -144708 +144715 diff --git a/test/other/codesize/test_codesize_cxx_except_wasm_legacy.size b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.size index 28cf96ad77953..cdbcd17b502d1 100644 --- a/test/other/codesize/test_codesize_cxx_except_wasm_legacy.size +++ b/test/other/codesize/test_codesize_cxx_except_wasm_legacy.size @@ -1 +1 @@ -142162 +142169 diff --git a/test/other/codesize/test_codesize_cxx_mangle.size b/test/other/codesize/test_codesize_cxx_mangle.size index 004d7d333c79a..8e8b38b5c13b0 100644 --- a/test/other/codesize/test_codesize_cxx_mangle.size +++ b/test/other/codesize/test_codesize_cxx_mangle.size @@ -1 +1 @@ -232724 +232731 diff --git a/test/other/codesize/test_codesize_cxx_noexcept.size b/test/other/codesize/test_codesize_cxx_noexcept.size index c0e3f17ce269c..232be2fc5f578 100644 --- a/test/other/codesize/test_codesize_cxx_noexcept.size +++ b/test/other/codesize/test_codesize_cxx_noexcept.size @@ -1 +1 @@ -131774 +131781 diff --git a/test/other/codesize/test_codesize_cxx_wasmfs.size b/test/other/codesize/test_codesize_cxx_wasmfs.size index 3b73c05a4a345..b592a30c75210 100644 --- a/test/other/codesize/test_codesize_cxx_wasmfs.size +++ b/test/other/codesize/test_codesize_cxx_wasmfs.size @@ -1 +1 @@ -169181 +169188 diff --git a/test/other/codesize/test_codesize_hello_O0.size b/test/other/codesize/test_codesize_hello_O0.size index aa9255e00128e..96b0a1d19abf4 100644 --- a/test/other/codesize/test_codesize_hello_O0.size +++ b/test/other/codesize/test_codesize_hello_O0.size @@ -1 +1 @@ -15101 +15113 diff --git a/test/other/codesize/test_codesize_minimal_pthreads.size b/test/other/codesize/test_codesize_minimal_pthreads.size index 5f7ea76a0569f..0f60aa5d0b843 100644 --- a/test/other/codesize/test_codesize_minimal_pthreads.size +++ b/test/other/codesize/test_codesize_minimal_pthreads.size @@ -1 +1 @@ -19394 +19405