Fix flake8 errors/warnings. NFC #23930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out ruff still doesn't support several flake8 warnings. I've enabled some more that are in preview-only mode. See emscripten-core#23085
sbc100
commented
Mar 14, 2025
| @@ -23,7 +23,7 @@ def run(cmd, **args): | |||
| def main(): | |||
| if run(['git', 'status', '-uno', '--porcelain']).strip(): | |||
| print('tree is not clean') | |||
| #return 1 | |||
| return 1 | |||
There was a problem hiding this comment.
This was actually a bug that accidentally submitted this.
kripken
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out ruff still doesn't support several flake8 warnings. I've enabled some more that are in preview-only mode.
See #23085