Unclear output when submitting to prod: not clear if submission succeeded or not

[corneliusroemer]

When submitting to prod (i.e. not passing -test) with version 9.0.0 (the latest available via bioconda), I get the following output, exit code is 0, no error shown, yet somehow it looks like the submission failed as I don't get the usual ERZ output. This is very confusing:

$ ena-webin-cli  -username Webin-redacted \
    -password redacted \
    -context genome \
    -manifest assembly/manifest.tsv \
    -submit
INFO : Your application version is 9.0.0
INFO : A new application version is available. Please download the latest version 9.0.1 from https://github.com/enasequence/webin-cli/releases

When I ran this before adding -test things worked fine:

$ ena-webin-cli  -username Webin-redacted \
    -password redacted \
    -context genome \
    -manifest assembly/manifest.tsv \
    -submit \
    -test
INFO : Your application version is 9.0.0
INFO : Submission has not been validated previously.
INFO : Creating report file: /Users/cr/code/loculus/ena-submission/assembly/./webin-cli.report
INFO : Submission(s) validated successfully.
INFO : Connecting to FTP server : webin2.ebi.ac.uk
INFO : Uploading file: /Users/cr/code/loculus/ena-submission/assembly/sequences.embl.gz
INFO : Uploading file: /Users/cr/code/loculus/ena-submission/assembly/chromosome_list.gz
INFO : Files have been uploaded to webin2.ebi.ac.uk.
INFO : The submission has been completed successfully. The following analysis accession was assigned to the submission: ERZ28399318
INFO : This was a TEST submission(s).

[corneliusroemer]

Ugh, I think I know what the difference is. You write into the directory that contains the files and don't resubmit if stuff is in there - so if you first do -test then remove the -test it won't actually submit. That's kind of annoying.

You should at least log something about this, like "There already exists a "webin-cli.report" in the directory XYZ, therefore aborting without new submission"