Skip to content

Remove unnecessary models.py file #6142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Remove unnecessary models.py file #6142

merged 1 commit into from
Aug 28, 2018

Conversation

jdufresne
Copy link
Contributor

Since Django 1.7, an empty models.py file is not required.

See https://docs.djangoproject.com/en/dev/releases/1.7/#app-loading-refactor

It is possible to omit models.py entirely if an application doesn’t have any models.

Since Django 1.7, an empty models.py file is not required.

See
https://docs.djangoproject.com/en/dev/releases/1.7/#app-loading-refactor

> It is possible to omit models.py entirely if an application doesn’t
> have any models.
@codecov-io
Copy link

Codecov Report

Merging #6142 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6142   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         128      128           
  Lines       17624    17624           
  Branches     1459     1459           
=======================================
  Hits        16951    16951           
  Misses        465      465           
  Partials      208      208

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Nice. Thanks!

@carltongibson carltongibson added this to the 3.9 Release milestone Aug 28, 2018
@carltongibson carltongibson merged commit 468cdd1 into encode:master Aug 28, 2018
@jdufresne jdufresne deleted the models branch May 1, 2019 13:07
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Since Django 1.7, an empty models.py file is not required.

See
https://docs.djangoproject.com/en/dev/releases/1.7/#app-loading-refactor

> It is possible to omit models.py entirely if an application doesn’t
> have any models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants