Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing usage as a context manager. #3

Closed
tomchristie opened this issue Jan 30, 2020 · 0 comments
Closed

Enforcing usage as a context manager. #3

tomchristie opened this issue Jan 30, 2020 · 0 comments

Comments

@tomchristie
Copy link
Member

tomchristie commented Jan 30, 2020

At an implementation level, the question of if httpx.AsyncClient should strictly enforce only being usable as a context-manager comes down to "should httpcore.AsyncConnectionPool strictly enforce only being usable as a context-manager?"

It's not the Client that might at some point start background tasks, but the connection pool implementation.

Further notes at encode/httpx#769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant