FIx tag processing logic. (#202)

Author: HowardvanRooijen

Solutions/Stacker.Cli/Domain/Universal/ContentItem.cs

@@ -20,7 +20,7 @@ public class ContentItem
 
     public string Id { get; internal set; }
 
-    public bool? Promote { get; internal set; }
+    public bool? Promote { get; set; }
 
     public DateTimeOffset? PromoteUntil { get; set; }
 
@@ -36,7 +36,7 @@ public string CleanSlug
         }
     }
 
-    public string Status { get; internal set; }
+    public string Status { get; set; }
 
     public List<string> Tags { get; set; }
 

Solutions/Stacker.Cli/Formatters/LongFormContentFormatter.cs

@@ -2,6 +2,7 @@
 // Copyright (c) Endjin Limited. All rights reserved.
 // </copyright>
 
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text;
@@ -50,9 +51,7 @@ public IEnumerable<string> Format(string campaignMedium, string campaignName, IE
                 int contentLength = content.Length + campaignTracking.Length + 1; // 1 = extra space before link
                 int tagsToInclude = 0;
 
-                item.Tags = item.Tags.Except(settings.ExcludedTags).OrderByDescending(word => settings.PriorityTags.IndexOf(word)).ToList();
-
-                foreach (string tag in item.Tags.Distinct())
+                foreach (string tag in item.Tags)
                 {
                     contentLength += tag.Length + 2; // 2 Offset = Space + #
                     if (contentLength <= this.maxContentLength)

Solutions/Stacker.Cli/Formatters/TweetFormatter.cs

@@ -59,9 +59,7 @@ public IEnumerable<string> Format(string campaignMedium, string campaignName, IE
                 int tweetLength = content.Length + campaignTracking.Length + 1; // 1 = extra space before link
                 int tagsToInclude = 0;
 
-                item.Tags = item.Tags.Except(settings.ExcludedTags).OrderByDescending(word => settings.PriorityTags.IndexOf(word)).ToList();
-
-                foreach (string tag in item.Tags.Distinct())
+                foreach (string tag in item.Tags)
                 {
                     tweetLength += tag.Length + 2; // 2 Offset = Space + #
                     if (tweetLength <= MaxContentLength)
@@ -74,7 +72,7 @@ public IEnumerable<string> Format(string campaignMedium, string campaignName, IE
                     }
                 }
 
-                foreach (string tag in item.Tags.Distinct().Take(tagsToInclude))
+                foreach (string tag in item.Tags.Take(tagsToInclude))
                 {
                     content.Append(" #");
                     content.Append(tag);

Solutions/Stacker.Cli/Tasks/ContentTasks.cs

@@ -97,6 +97,8 @@ public async Task<IEnumerable<ContentItem>> LoadContentItemsAsync(
 
         List<ContentItem> content = JsonSerializer.Deserialize<List<ContentItem>>(fileContent);
 
+        content = content.Where(p => p.Promote is true).ToList();
+
         if (publicationPeriod != PublicationPeriod.None)
         {
             AnsiConsole.MarkupLineInterpolated($"[yellow1]Publication Period:[/] {publicationPeriod}");
@@ -138,12 +140,14 @@ public async Task<IEnumerable<ContentItem>> LoadContentItemsAsync(
 
         foreach (ContentItem contentItem in content)
         {
+            contentItem.Tags = contentItem.Tags.Except(this.settings.ExcludedTags, StringComparer.InvariantCultureIgnoreCase).ToList();
+
             // Use TagAliases to convert tags into their canonical form.
             contentItem.Tags = contentItem.Tags?.Select(tag =>
             {
                 TagAliases matchedAlias = this.settings.TagAliases.FirstOrDefault(alias => alias.Aliases.Any(a => a == tag));
                 return matchedAlias != null ? matchedAlias.Tag : tag.Replace("-", " ").Replace(" ", string.Empty);
-            }).ToList();
+            }).Distinct().OrderByDescending(word => this.settings.PriorityTags.IndexOf(word)).ToList();
         }
 
         // Sort so that content with the shortest lifespan are first.