Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode Error Should Not Implicitly Lead to Mumble #2

Open
domenukk opened this issue May 3, 2021 · 1 comment
Open

Unicode Error Should Not Implicitly Lead to Mumble #2

domenukk opened this issue May 3, 2021 · 1 comment

Comments

@domenukk
Copy link
Member

domenukk commented May 3, 2021

As previously discussed in the python lib, unicode decode errors should be explicitly handled by checker authors, see:
enowars/enochecker#77

Currently, a decode error would result in Mumble, which is not correct in many situations (for example, if a field stores unprocessed data that can be placed by other teams).
I think this From should therefore go:

impl From<FromUtf8Error> for CheckerError {

@domenukk
Copy link
Member Author

domenukk commented May 3, 2021

The only benefit the Rust implementation has over python is that one must explicitly call ? on the decode - however I am not sure that service authors will correctly use this power.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant