Remove duplicated IR ASTs for static methods (#13962)

Implements the newly specified behavior of method invocations from #13961.

Co-authored-by: Jaroslav Tulach <[email protected]>

Author: Akirathan

distribution/lib/Standard/Base/0.0.0-dev/docs/api/Data/Numbers.md

@@ -86,13 +86,14 @@
     - sqrt self -> Standard.Base.Any.Any
     - tan self -> Standard.Base.Any.Any
     - tanh self -> Standard.Base.Any.Any
+- Standard.Base.Data.Numbers.Positive_Integer.new integer:Standard.Base.Data.Numbers.Integer -> Standard.Base.Any.Any
 - Standard.Base.Data.Numbers.Float.from that:Standard.Base.Data.Numbers.Integer -> Standard.Base.Data.Numbers.Float
 - type Number_Parse_Error
     - Error text:Standard.Base.Any.Any
     - to_display_text self -> Standard.Base.Any.Any
+- Standard.Base.Data.Numbers.Integer.from that:Standard.Base.Data.Numbers.Positive_Integer -> Standard.Base.Data.Numbers.Integer
 - type Positive_Integer
     - Value integer:Standard.Base.Data.Numbers.Integer
     - new integer:Standard.Base.Data.Numbers.Integer -> Standard.Base.Any.Any
 - Standard.Base.Data.Numbers.Positive_Integer.from that:Standard.Base.Data.Numbers.Integer -> Standard.Base.Data.Numbers.Positive_Integer
-- Standard.Base.Data.Numbers.Integer.from that:Standard.Base.Data.Numbers.Positive_Integer -> Standard.Base.Data.Numbers.Integer
 - Standard.Base.Data.Ordering.Comparable.from that:Standard.Base.Data.Numbers.Positive_Integer -> Standard.Base.Data.Ordering.Comparable

distribution/lib/Standard/Base/0.0.0-dev/docs/api/Data/Ordering.md

@@ -7,17 +7,18 @@
     - >= self that:Standard.Base.Data.Ordering.Comparable -> Standard.Base.Data.Boolean.Boolean!Standard.Base.Errors.Common.Incomparable_Values
     - new value:Standard.Base.Any.Any comparator:Standard.Base.Any.Any -> Standard.Base.Data.Ordering.Comparable
 - Standard.Base.Data.Ordering.Ordering.and_then self ~other:Standard.Base.Any.Any -> Standard.Base.Any.Any
+- Standard.Base.Data.Ordering.Ordering.compare x:Standard.Base.Any.Any y:Standard.Base.Any.Any -> Standard.Base.Data.Ordering.Ordering!Standard.Base.Errors.Common.Incomparable_Values
 - Standard.Base.Data.Ordering.Ordering.from_sign sign:Standard.Base.Any.Any -> Standard.Base.Any.Any
 - Standard.Base.Data.Ordering.Ordering.hash x:Standard.Base.Any.Any -> Standard.Base.Any.Any
 - Standard.Base.Data.Ordering.Ordering.to_sign self -> Standard.Base.Any.Any
 - Standard.Base.Data.Ordering.Comparable.from that:Standard.Base.Any.Any -> Standard.Base.Data.Ordering.Comparable
+- Standard.Base.Data.Ordering.Comparable.from that:Standard.Base.Data.Ordering.Ordering -> Standard.Base.Data.Ordering.Comparable
 - type Ordering
     - Equal
     - Greater
     - Less
     - and_then self ~other:Standard.Base.Any.Any -> Standard.Base.Any.Any
+    - compare x:Standard.Base.Any.Any y:Standard.Base.Any.Any -> Standard.Base.Data.Ordering.Ordering!Standard.Base.Errors.Common.Incomparable_Values
     - from_sign sign:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - hash x:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - to_sign self -> Standard.Base.Any.Any
-    - compare x:Standard.Base.Any.Any y:Standard.Base.Any.Any -> Standard.Base.Data.Ordering.Ordering!Standard.Base.Errors.Common.Incomparable_Values
-- Standard.Base.Data.Ordering.Comparable.from that:Standard.Base.Data.Ordering.Ordering -> Standard.Base.Data.Ordering.Comparable

distribution/lib/Standard/Base/0.0.0-dev/docs/api/Data/Read/Return_As.md

@@ -5,6 +5,7 @@
     - make_return self input:Standard.Base.Data.Read.Many_Files_List.Many_Files_List objects:(Standard.Base.Data.Vector.Vector Standard.Base.Any.Any) on_problems:Standard.Base.Errors.Problem_Behavior.Problem_Behavior -> Standard.Base.Any.Any
     - to_display_text self -> Standard.Base.Data.Text.Text
     - to_text self -> Standard.Base.Data.Text.Text
+- Standard.Base.Data.Read.Return_As.Return_As.from that:Standard.Base.Data.Read.Return_As.Return_As_Base -> Standard.Base.Data.Read.Return_As.Return_As
 - type Return_As_Base
     - As_Vector
     - get_dropdown_options -> Standard.Base.Any.Any
@@ -15,4 +16,3 @@
     - _get_known_return_classes -> Standard.Base.Data.Vector.Vector
     - new typ:Standard.Base.Any.Any -> Standard.Base.Data.Read.Return_As.SPI
 - replace_with_nothing_and_propagate vector:(Standard.Base.Data.Vector.Vector Standard.Base.Any.Any) on_problems:Standard.Base.Errors.Problem_Behavior.Problem_Behavior -> Standard.Base.Any.Any
-- Standard.Base.Data.Read.Return_As.Return_As.from that:Standard.Base.Data.Read.Return_As.Return_As_Base -> Standard.Base.Data.Read.Return_As.Return_As

distribution/lib/Standard/Base/0.0.0-dev/docs/api/Enso_Cloud/Enso_Secret.md

@@ -27,13 +27,13 @@
     - to_js_object self -> Standard.Base.Any.Any
     - to_text self -> Standard.Base.Any.Any
     - update_value self new_value:Standard.Base.Data.Text.Text -> Standard.Base.Any.Any
-- as_credential_reference secret:Standard.Base.Enso_Cloud.Enso_Secret.Enso_Secret -> Standard.Base.Enso_Cloud.Enso_Secret.CredentialReference
-- as_hideable_value value:(Standard.Base.Data.Text.Text|Standard.Base.Enso_Cloud.Enso_Secret.Enso_Secret|Standard.Base.Enso_Cloud.Enso_Secret.Derived_Secret_Value) factory:Standard.Base.Any.Any= -> Standard.Base.Any.Any
 - secret_asset_uri secret:Standard.Base.Any.Any -> Standard.Base.Any.Any
-- secret_resource_uri secret:Standard.Base.Any.Any -> Standard.Base.Any.Any
 - Standard.Base.Enso_Cloud.Enso_Secret.Derived_Secret_Value.from that:Standard.Base.Enso_Cloud.Enso_Secret.Enso_Secret -> Standard.Base.Enso_Cloud.Enso_Secret.Derived_Secret_Value
 - type Enso_Secret_Error
     - Access_Denied
     - Not_Found resolved_path:Standard.Base.Any.Any
     - to_display_text self -> Standard.Base.Any.Any
+- as_credential_reference secret:Standard.Base.Enso_Cloud.Enso_Secret.Enso_Secret -> Standard.Base.Enso_Cloud.Enso_Secret.CredentialReference
+- as_hideable_value value:(Standard.Base.Data.Text.Text|Standard.Base.Enso_Cloud.Enso_Secret.Enso_Secret|Standard.Base.Enso_Cloud.Enso_Secret.Derived_Secret_Value) factory:Standard.Base.Any.Any= -> Standard.Base.Any.Any
+- secret_resource_uri secret:Standard.Base.Any.Any -> Standard.Base.Any.Any
 - Standard.Base.Enso_Cloud.Enso_Secret.Derived_Secret_Value.from that:Standard.Base.Data.Text.Text -> Standard.Base.Enso_Cloud.Enso_Secret.Derived_Secret_Value

distribution/lib/Standard/Base/0.0.0-dev/src/Internal/Ordering_Helpers.enso

@@ -25,7 +25,7 @@ type Default_Comparator
        ---
     compare : Any -> Any -> (Ordering|Nothing)
     compare x y =
-        case Any.== x y of
+        case x == y of
             True -> Ordering.Equal
             False ->
                 case Default_Comparator.less_than_builtin x y of

distribution/lib/Standard/Table/0.0.0-dev/docs/api/Fixed_Width/Fixed_Width_Format.md

@@ -17,6 +17,9 @@
     - from_descriptions descs:(Standard.Base.Data.Vector.Vector Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Column_Description) -> Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout
     - missing_layout_argument -> Standard.Base.Any.Any
     - to_js_object self -> Standard.Base.Any.Any
+- _make_fixed_width_layout_widget display:Standard.Base.Metadata.Display= -> Standard.Base.Metadata.Widget
+- Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout.from that:Standard.Table.Table.Table -> Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout
+- Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout.from that:Standard.Table.Column.Column -> Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout
 - Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout.from that:Standard.Base.Data.Vector.Vector -> Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout
 - Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout.from that:Standard.Base.Function.Function -> Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout
 - type Fixed_Width_Layout_Entry
@@ -25,6 +28,3 @@
     - Left
     - Right
     - to_java self -> Standard.Table.Fixed_Width.Fixed_Width_Format.Justification
-- _make_fixed_width_layout_widget display:Standard.Base.Metadata.Display= -> Standard.Base.Metadata.Widget
-- Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout.from that:Standard.Table.Table.Table -> Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout
-- Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout.from that:Standard.Table.Column.Column -> Standard.Table.Fixed_Width.Fixed_Width_Format.Fixed_Width_Layout

docs/runtime/compiler-ir.md

@@ -29,6 +29,9 @@ enso --no-compile-dependencies --no-ir-caches --vm.D enso.compiler.RemoveUnusedI
 
 ## Dumping IR
 
+Note that to properly dump module from standard library, **it is recommended to
+run with --no-ir-caches**.
+
 The IR can be visualized using the `enso.compiler.dumpIr` system property. The
 property value has format `<module-name>[:<dump-level>]`, where `module-name` is
 a substring of a module to dump and `dump-level` is an optional integer which

engine/runtime-compiler-dump-igv/src/main/java/org/enso/compiler/dump/igv/EnsoModuleAST.java

@@ -429,8 +429,11 @@ private ASTNode buildTree(Pattern pattern) {
   private ASTNode buildTree(CallArgument argument) {
     return switch (argument) {
       case CallArgument.Specified specifiedArg -> {
-        Map<String, Object> props = Map.of("argName", specifiedArg.name());
-        var node = newNode(specifiedArg, props);
+        var node = newNode(specifiedArg);
+        if (specifiedArg.name().isDefined()) {
+          var nameNode = buildTree(specifiedArg.name().get());
+          createEdge(node, nameNode, "name");
+        }
         var valueNode = buildTree(specifiedArg.value());
         createEdge(node, valueNode, "value");
         yield node;

engine/runtime-compiler/src/main/java/org/enso/compiler/pass/analyse/types/TypePropagation.java

@@ -6,6 +6,7 @@
 import org.enso.compiler.MetadataInteropHelpers;
 import org.enso.compiler.common.NameResolutionAlgorithm;
 import org.enso.compiler.core.CompilerError;
+import org.enso.compiler.core.ConstantsNames;
 import org.enso.compiler.core.IR;
 import org.enso.compiler.core.ir.CallArgument;
 import org.enso.compiler.core.ir.Expression;
@@ -355,8 +356,13 @@ private TypeRepresentation processSingleApplication(
       Application.Prefix relatedIR,
       LocalBindingsTyping localBindingsTyping) {
     if (argument.name().isDefined()) {
-      // TODO named arguments are not yet supported
-      return null;
+      var isSelf = ConstantsNames.SELF_ARGUMENT.equals(argument.name().get().name());
+      if (!isSelf) {
+        // TODO named arguments are not yet supported
+        return null;
+      } else {
+        // static invocation syntax is supported
+      }
     }
 
     switch (functionType) {
@@ -370,7 +376,11 @@ private TypeRepresentation processSingleApplication(
 
       case TypeRepresentation.UnresolvedSymbol unresolvedSymbol -> {
         return processUnresolvedSymbolApplication(
-            unresolvedSymbol, argument.value(), localBindingsTyping, relatedIR);
+            unresolvedSymbol,
+            argument.value(),
+            isStaticMethodInvocation(relatedIR),
+            localBindingsTyping,
+            relatedIR);
       }
 
       default -> {
@@ -399,6 +409,7 @@ private AtomTypeDefinition findTypeDefinition(QualifiedName name) {
   private TypeRepresentation processUnresolvedSymbolApplication(
       TypeRepresentation.UnresolvedSymbol function,
       Expression argument,
+      boolean isStaticMethodInvocation,
       LocalBindingsTyping localBindingsTyping,
       IR relatedWholeApplicationIR) {
     var argumentType = tryInferringType(argument, localBindingsTyping);
@@ -421,16 +432,23 @@ private TypeRepresentation processUnresolvedSymbolApplication(
             }
           }
 
-          // Then we resolve the _static_ `method` on the `Type` - by looking at the eigen type.
-          // We resolve static calls on the eigen type. It should also contain registrations of the
-          // static variants of member methods, so we don't need to inspect member scope.
-          var staticScope = TypeScopeReference.atomEigenType(typeObject.name());
+          TypeScopeReference staticScope;
+          if (isStaticMethodInvocation) {
+            staticScope = TypeScopeReference.atomType(typeObject.name());
+          } else {
+            staticScope = TypeScopeReference.atomEigenType(typeObject.name());
+          }
           var resolvedStaticMethod = methodTypeResolver.resolveMethod(staticScope, function.name());
           if (resolvedStaticMethod == null) {
             encounteredNoSuchMethod(
                 relatedWholeApplicationIR, argumentType, function.name(), MethodCallKind.STATIC);
           }
-          return resolvedStaticMethod;
+          if (isStaticMethodInvocation) {
+            var withSelf = TypeRepresentation.buildStaticMethod(typeObject, resolvedStaticMethod);
+            return withSelf;
+          } else {
+            return resolvedStaticMethod;
+          }
         }
       }
 
@@ -493,6 +511,23 @@ private boolean isConstructorOrType(String name) {
     return Character.isUpperCase(firstCharacter);
   }
 
+  /**
+   * @see <a
+   *     href="https://github.com/enso-org/enso/tree/8c14901627d4d716a67da95d210c7b60f89d30b2/docs/types/dynamic-dispatch.md#static-method-invocation">static
+   *     method invocation specification</a>
+   */
+  private static boolean isStaticMethodInvocation(Application.Prefix applicationIR) {
+    if (applicationIR.arguments().length() >= 2) {
+      var secondArg = applicationIR.arguments().apply(1);
+      return isNamedSelfArgument(secondArg);
+    }
+    return false;
+  }
+
+  private static boolean isNamedSelfArgument(CallArgument arg) {
+    return arg.name().isDefined() && arg.name().get().name().equals(ConstantsNames.SELF_ARGUMENT);
+  }
+
   private TypeRepresentation resolveConstructorOnType(
       TypeRepresentation.TypeObject typeObject,
       String constructorName,

engine/runtime-compiler/src/main/java/org/enso/compiler/pass/analyse/types/TypeRepresentation.java

@@ -39,6 +39,11 @@ static TypeRepresentation buildFunction(
     return reversed.stream().reduce(result, (acc, arg) -> new ArrowType(arg, acc));
   }
 
+  static TypeRepresentation buildStaticMethod(
+      TypeRepresentation.TypeObject selfType, TypeRepresentation instanceMethod) {
+    return new ArrowType(selfType.instanceType(), instanceMethod);
+  }
+
   record TopType() implements TypeRepresentation {
     @Override
     public String toString() {