Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing widget on new_text in Column.text_replace #12188

Open
radeusgd opened this issue Jan 29, 2025 · 1 comment
Open

Missing widget on new_text in Column.text_replace #12188

radeusgd opened this issue Jan 29, 2025 · 1 comment
Assignees
Labels
--bug Type: bug -libs Libraries: New libraries to be implemented

Comments

@radeusgd
Copy link
Member

radeusgd commented Jan 29, 2025

When using the product I've encountered that Column.text_replace has no widget for new_text. Thus it is impossible to use it using the widgets - I need to ctrl+click to edit the node in code mode to be able to specify it.

Image

For comparison, the same thing on Table.text_replace works ok:

Image

@farmaazon
Copy link
Contributor

As I see, the text_replace definition just misses configuration for new_text

    @term make_regex_text_widget
    text_replace : Text | Regex | Column -> Text | Column -> Case_Sensitivity -> Boolean -> Column
    text_replace self (term : Text | Regex | Column = "") new_text="" case_sensitivity:Case_Sensitivity=..Sensitive only_first=False =

For comparison, definition of Table's text_replace:

@columns (Widget_Helpers.make_column_name_multi_selector add_regex=True add_by_type=True)
    @term (Widget_Helpers.make_column_ref_by_name_selector add_regex=True add_text=True add_named_pattern=True)
    @new_text (Widget_Helpers.make_column_ref_by_name_selector add_text=True)
    text_replace : Vector (Integer | Text | Regex | By_Type) | Text | Integer | Regex | By_Type -> Text | Column | Column_Ref | Expression | Regex -> Text | Column | Column_Ref | Expression -> Case_Sensitivity -> Boolean -> Column
    text_replace self columns (term : Text | Column | Column_Ref | Expression | Regex = "") (new_text : Text | Column | Column_Ref | Expression = "") case_sensitivity:Case_Sensitivity=..Sensitive only_first:Boolean=False =

@farmaazon farmaazon added -libs Libraries: New libraries to be implemented and removed triage labels Jan 30, 2025
@jdunkerley jdunkerley self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -libs Libraries: New libraries to be implemented
Projects
Status: New
Development

No branches or pull requests

3 participants