Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native enso bundle contains GraalVM, but --jvm cannot find it #12302

Closed
JaroslavTulach opened this issue Feb 18, 2025 · 5 comments · Fixed by #12318
Closed

Native enso bundle contains GraalVM, but --jvm cannot find it #12302

JaroslavTulach opened this issue Feb 18, 2025 · 5 comments · Fixed by #12318
Assignees

Comments

@JaroslavTulach
Copy link
Member

JaroslavTulach commented Feb 18, 2025

While testing enso-bundle download as described here I realized that while running tests in native mode works when calling it with --jvm argument, it fails:

$ ./enso/dist/2025.1.1-nightly.2025.2.18/bin/enso --jvm --run /enso/test/Table_Tests
[WARN] [2025-02-18T06:59:58+01:00] [org.enso.runtimeversionmanager.components.GraalVersionManager] Runtime search path `/home/devel/.local/share/enso/runtime` is not a directory
[WARN] [2025-02-18T06:59:58+01:00] [org.enso.runner.JavaFinder] No appropriate JDK found in the distribution runtimes. Trying system-wide JDK.
[WARN] [2025-02-18T06:59:58+01:00] [org.enso.runner.JavaFinder] No JDK found in JAVA_HOME. Trying java on PATH.
[WARN] [2025-02-18T06:59:58+01:00] [org.enso.runner.JavaFinder] No JDK found on PATH. Cannot start the runtime.
Cannot find java executable

that's unfortunate as ensoup (part of the same bundle download) is able to find JVM:

$ ./enso/bin/ensoup run /enso/test/Table_Tests

What's wrong?

Probably ensoup is using the portable distribution layout while the handling of --jvm switch isn't - maybe ignoring .enso.portable. CCing @radeusgd

@JaroslavTulach
Copy link
Member Author

I had to

$ mv ~/.local/share/enso/ ~/.local/share/enso.bak

to simulate the problem. As the ./bin/enso --jvm properly searches ~/.local/share/enso/ - it just doesn't seem to deal correctly with .enso.portable bundle.

@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board Feb 18, 2025
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Feb 18, 2025

Per @Akirathan request here is a test with AppImage. AppImage, dmg and Windows case will be important if we change project-manager to use --jvm flag instead of the current java based solution:

$ ./enso-linux-x86_64-2025.1.1-nightly.2025.2.18.AppImage --appimage-extract
$ ./squashfs-root/resources/enso/dist/2025.1.1-nightly.2025.2.18/bin/enso --jvm --run ~/NetBeansProjects/enso/enso/test/Table_Tests
[WARN] [org.enso.runtimeversionmanager.components.GraalVersionManager] Runtime search path `/home/devel/.local/share/enso/runtime` is not a directory
[WARN] [org.enso.runner.JavaFinder] No appropriate JDK found in the distribution runtimes. Trying system-wide JDK.
[WARN] [org.enso.runner.JavaFinder] No JDK found in JAVA_HOME. Trying java on PATH.
[WARN] [org.enso.runner.JavaFinder] No JDK found on PATH. Cannot start the runtime.
Cannot find java executable

it is also broken. There is:

$ ls -1 squashfs-root/resources/enso/.enso.bundle 
squashfs-root/resources/enso/.enso.bundle

thus probably this case shall work as well. Right @radeusgd? Walk up from bin/enso, locate .enso.bundle and search for GraalVM among its runtimes. @radeusgd do you have any idea why there is .enso.portable once and .enso.bundle in the other case?

@JaroslavTulach
Copy link
Member Author

Please note that the download section for Enso Engine links to the enso-bundle, not enso-engine!

Enso Engine or Bundle

@Akirathan Akirathan moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 19, 2025
@enso-bot
Copy link

enso-bot bot commented Feb 19, 2025

Pavel Marek reports a new STANDUP for yesterday (2025-02-18):

Progress: - Why do we have so many assets in every release?

GitHub
Let's investigate the amount of assets for every release. A link to a recent release is https://github.com/enso-org/enso/releases/tag/untagged-aed0b8c4d7d0b238bf33 For every platform, we have 6 ass...

@enso-bot
Copy link

enso-bot bot commented Feb 19, 2025

Pavel Marek reports a new STANDUP for today (2025-02-19):

Progress: - Run a single benchmark on the CI:

@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

2 participants