Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadowing identifiers produces warnings #9863

Closed
wants to merge 8 commits into from
Closed

Shadowing identifiers produces warnings #9863

wants to merge 8 commits into from

Conversation

Akirathan
Copy link
Member

Fixes #8868

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label May 3, 2024
@Akirathan Akirathan self-assigned this May 3, 2024
@Akirathan Akirathan force-pushed the wip/akirathan/8868-shadowing-warn branch from 2b61d26 to 026ea1a Compare June 11, 2024 08:39
Akirathan added 2 commits June 11, 2024 11:11
@Akirathan
Fix build after merge of develop
94b1adb
@Akirathan
Remove renamed static method test.
4ced5da 
Importing static method and renaming it is not possible.
@Akirathan Akirathan mentioned this pull request Jun 11, 2024
Open
@Akirathan
Copy link
Member Author

Closing this PR. The associated issue is now marked as on-hold in #8868 (comment)

@Akirathan Akirathan closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 Awaiting requested review from 4e6 4e6 will be requested when the pull request is marked ready for review 4e6 is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach will be requested when the pull request is marked ready for review JaroslavTulach is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp will be requested when the pull request is marked ready for review hubertp is a code owner

Assignees

@Akirathan Akirathan

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imported name shadowed by local type not reported
1 participant
@Akirathan