Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fully qualified names in type signatures #12263

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Allow fully qualified names in type signatures #12263

wants to merge 4 commits into from

Conversation

Akirathan
Copy link
Member

Fixes #8997

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan added CI: No changelog needed Do not require a changelog entry for this PR. CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Feb 12, 2025
@Akirathan Akirathan self-assigned this Feb 12, 2025
@Akirathan
Copy link
Member Author

Akirathan commented Feb 12, 2025 •
edited
Loading

BindingsMapResolutionTest.resolveQualifiedName_FromSingleImport test fails. This is the minimal reproducer - The original reproducer fails to resolve the FQN from the bindings map in the TypeNames IR pass.

To properly fix the issue, we should ensure that the BindingsMap.resolveQualifiedName works for these cases. Let's explore it...

@Akirathan Akirathan mentioned this pull request Feb 12, 2025
Open
@JaroslavTulach JaroslavTulach mentioned this pull request Feb 19, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 Awaiting requested review from 4e6 4e6 will be requested when the pull request is marked ready for review 4e6 is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach will be requested when the pull request is marked ready for review JaroslavTulach is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp will be requested when the pull request is marked ready for review hubertp is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Akirathan Akirathan

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fully Qualified Names are not allowed in type signatures
1 participant
@Akirathan