Adds deployment configuration for extproc #98
Merged
+425
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
commented
Jan 14, 2025
| @@ -122,6 +132,45 @@ type LLMRouteRuleMatch struct { | |||
| Headers []gwapiv1.HTTPHeaderMatch `json:"headers,omitempty"` | |||
| } | |||
|
|
|||
| type LLMRouteFilterConfig struct { | |||
There was a problem hiding this comment.
This indirection will help us deprecate and keep the API clean before/after extproc removal per #90
fyi I will work on the compatibility policy doc next
There was a problem hiding this comment.
Also, this could be AIGatewayFilterConfig per #76
There was a problem hiding this comment.
right, let's change it all together.
Comment on lines
+161
to
+169
| // Replicas is the number of desired pods of the external process deployment. | ||
| // | ||
| // +optional | ||
| Replicas *int32 `json:"replicas,omitempty"` | ||
| // Resources required by the external process container. | ||
| // More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ | ||
| // | ||
| // +optional | ||
| Resources *corev1.ResourceRequirements `json:"resources,omitempty"` |
There was a problem hiding this comment.
i could've used either the embedding of appv1.DeploymentSpec or EG's KubernetesDeploymentSpec but both seems too complex for this purpose in addition to the impl cost. we can add additional fields on demand.
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
yuzisun
approved these changes
Jan 16, 2025
|
@mathetake there is a conflict to resolve |
|
aha ok |
Signed-off-by: Takeshi Yoneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82