Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename inputSchema and outputSchema properties to schema #89

Open
cmaddalozzo opened this issue Jan 13, 2025 · 3 comments
Open

Rename inputSchema and outputSchema properties to schema #89

cmaddalozzo opened this issue Jan 13, 2025 · 3 comments
Milestone
v.0.1.0

Comments

@cmaddalozzo
Copy link

In the LLMRouteSpec we refer to the schema as inputSchema and in the LLMBackendSpec we refer to the schema as outputSchema. While this is technically true I think it is clearer and more accurate to call these fields schema as it represent both of the respective inputs and outputs.
@mathetake
Copy link
Member

sounds reasonable to me and no objection

@mathetake
Copy link
Member

mathetake commented Jan 13, 2025 •
edited
Loading

wdyt @envoyproxy/ai-gateway-assignable @envoyproxy/ai-gateway-maintainers

@mathetake
Copy link
Member

if there's no objection by tomorrow could you go ahead and send a patch? @cmaddalozzo

@mathetake mathetake added this to the v.0.1.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v.0.1.0
Development

No branches or pull requests
2 participants
@cmaddalozzo @mathetake