Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opt-out of always adding healthcheck response headers in the HTTP healthcheck filter #37947

Open
henrymwang opened this issue Jan 9, 2025 · 0 comments
Labels
area/http_filter enhancement Feature requests. Not bugs or questions.

Comments

@henrymwang
Copy link
Contributor

Title: Allow opt-out of always adding healthcheck response headers in the HTTP healthcheck filter

Description:
The HTTP health check filter adds response headers in certain cases:

  • x-envoy-immediate-health-check-fail, for service-mesh usecases
  • x-envoy-upstream-healthchecked-cluster

in other cases (non service-mesh Envoy) it may not be useful to always have those headers added. In our case, we also use the healthcheck filter in "no pass through mode" instead of a direct response route since we rely on the status code to change during server draining.

We'd like to add config to opt out of writing those headers in the H/C filter.

We can prepare the patch for this if it's acceptable.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@henrymwang henrymwang added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jan 9, 2025
@zuercher zuercher added area/http_filter and removed triage Issue requires triage labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/http_filter enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

2 participants