make smoke tests more reliable

kentcdodds · kentcdodds · commit 13087bf93b76 · 2024-09-19T14:10:07.000-06:00
diff --git a/exercises/01.init/01.problem.static/tests/solution.test.js b/exercises/01.init/01.problem.static/tests/solution.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/01.init/01.solution.static/tests/solution.test.js b/exercises/01.init/01.solution.static/tests/solution.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/02.server-components/01.problem.rsc/tests/solution.test.js b/exercises/02.server-components/01.problem.rsc/tests/solution.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/02.server-components/01.solution.rsc/tests/solution.test.js b/exercises/02.server-components/01.solution.rsc/tests/solution.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/02.server-components/02.problem.async-components/tests/solution.test.js b/exercises/02.server-components/02.problem.async-components/tests/solution.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/02.server-components/02.solution.async-components/tests/solution.test.js b/exercises/02.server-components/02.solution.async-components/tests/solution.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/02.server-components/04.problem.server-context/tests/solution.test.js b/exercises/02.server-components/04.problem.server-context/tests/solution.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/02.server-components/04.solution.server-context/tests/solution.test.js b/exercises/02.server-components/04.solution.server-context/tests/solution.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/03.client-components/01.problem.loader/tests/smoke.test.js b/exercises/03.client-components/01.problem.loader/tests/smoke.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/03.client-components/01.solution.loader/tests/smoke.test.js b/exercises/03.client-components/01.solution.loader/tests/smoke.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/03.client-components/02.problem.module-resolution/tests/smoke.test.js b/exercises/03.client-components/02.problem.module-resolution/tests/smoke.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
diff --git a/exercises/03.client-components/02.solution.module-resolution/tests/smoke.test.js b/exercises/03.client-components/02.solution.module-resolution/tests/smoke.test.js
@@ -16,6 +16,8 @@ test('should display the home page and perform search', async ({ page }) => {
 	// Verify URL change with search params
 	await expect(page).toHaveURL('/?search=hopper')
 
+	await page.waitForLoadState('networkidle')
+
 	// Verify filtered results
 	const shipLinks = page
 		.getByRole('list')
