Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Embedded - Fix Authentication #129

Closed
3 tasks done
richard-cox opened this issue Jun 7, 2022 · 7 comments
Closed
3 tasks done

[UI] Embedded - Fix Authentication #129

richard-cox opened this issue Jun 7, 2022 · 7 comments

Comments

@richard-cox
Copy link
Member

richard-cox commented Jun 7, 2022

  • Embedded UI uses the default user secret within basic auth for api requests
  • Default user is now going to be optional (see Don't create a default (non-admin) user by default helm-charts#214)
  • In addition the password in the secret is now bencrpt'd, yet we need it in plain text to make the api requests
  • Possible workaround - dashboard automatically creates an epinio-ui user with password in plain text. it will only be usable by the epinio ui and not the cli.
  • in the future though the dashboard should handle different creds or epinio uses the rancher auth provider

Tasks

Preview Give feedback
  1. area/embedded epinio-1.11.0-2 kind/enhancement
  2. area/embedded kind/enhancement

Note - #360 has been removed from this epic, given that it might be a while until this is achievable

@jimmykarily jimmykarily moved this to Icebox in Epinio planning Jun 7, 2022
@richard-cox richard-cox changed the title [UI] Embedded - Fall back on admin user as connection credentials [UI] Embedded - Fix Authentication Jun 7, 2022
@richard-cox richard-cox added this to the UI 1.1 milestone Jun 15, 2022
@juadk
Copy link
Contributor

juadk commented Jun 24, 2022

When we talked about the broken dashboard, you mentioned that issue to me but is it really related to the fact that we cannot see the epinio icon in the nav menu anymore? (just to be sure).
I can still install epinio through the marketplace but once done, there is no button to access to the epinio instance.

@richard-cox
Copy link
Member Author

richard-cox commented Jun 24, 2022

When we talked about the broken dashboard, you mentioned that issue to me but is it really related to the fact that we cannot see the epinio icon in the nav menu anymore? (just to be sure).
I can still install epinio through the marketplace but once done, there is no button to access to the epinio instance.

That's the expected behaviour, the button is part of the embedded solution and takes the user to the embedded pages. Some rancher products (kube warden, neuvector, etc) have links within the cluster explorer's side nav (not burger menu side nav) for standalone ui's... but they take the user away from the dashboard.

@juadk
Copy link
Contributor

juadk commented Jun 24, 2022

ok so we definitively have to wait for that issue to be resolved to progress.

@richard-cox richard-cox added the kind/bug Something isn't working label Jul 18, 2022
@thehejik
Copy link
Contributor

@richard-cox Hello, our CI is still using non-existing Epinio icon/button in the Rancher UI to access Epinio dashboard so the Rancher UI tests are broken then.

There is a couple of other ways to get the link but most Rancher products offer an icon, so I think it would be nice to have it.

Do you think the lack of icon deserves a separate card to prioritize this issue or should we do a workaround in CI?

@richard-cox
Copy link
Member Author

@thehejik To clear a few things up, there are two 'modes' that the UI has

  • Standalone - The UI is served up by the UI backend, and is deployed and released as part of the general Epinio release.
  • Embedded - The UI is served up by the Rancher Dashboard and has a separate build/package for the Rancher Management product. This is not currently released (but we hope to in the future) and is blocked on this issue ([UI] Embedded - Fix Authentication #129).

An alternative mode would be, as i think you were implying from your comment, is to have links from the Rancher Dashboard to the standalone UI. That is currently out of scope and would be in a different form (the link would appear as part of the cluster explorer area rather than a menu item in the burger menu).

@richard-cox richard-cox removed this from the UI 1.2 milestone Feb 6, 2023
@richard-cox richard-cox moved this to Next Up in UI Apr 17, 2023
@richard-cox richard-cox added this to UI Apr 17, 2023
@richard-cox richard-cox self-assigned this May 25, 2023
@richard-cox richard-cox moved this from Next Up to In progress in UI May 25, 2023
@richard-cox richard-cox moved this from Icebox to In Progress in Epinio planning May 25, 2023
@richard-cox richard-cox moved this from In progress to Next Up in UI May 26, 2023
@richard-cox richard-cox moved this from Next Up to Backlog in UI Jun 29, 2023
@richard-cox
Copy link
Member Author

  • local user - possible cloud credentials / secret , use rancher proxy & cloud credential / secret id

@richard-cox
Copy link
Member Author

Closing, tested as part of #358

@github-project-automation github-project-automation bot moved this from To Review to Done in Epinio planning Nov 20, 2023
@github-project-automation github-project-automation bot moved this from To Test (Embedded) to Done in UI Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
Development

No branches or pull requests

3 participants